Commit 02e73872 authored Nov 06, 2015 by Srinu Jella Committed by Andre Eisenbach Mar 14, 2016

Free allocation tracker hash map entries to reduce memory pressure

Use case:
A2DP playback becomes choppy after long hours of testing.

Steps:
1. installed 3rd party app that performs recurring LE scans.
2. Leave phone to run overnight.
3. After 24h+, connect a Bluetooth headset and music is very choppy.

Root cause:
The memory allocation tracker has support for double free check
where it stores all allocations in hash map but it never get
removed to track double free issue, A2DP memory allocation is
taking more time and leading to choppyness.

Fix:
Free the hash map entry to avoid memory leak from
allocation tracker.

Bug: 27621407
Change-Id: If57bd0b89c1d9b99c4f066c537a9e0fa49bc093f

parent 4012eff3

system/osi/src/allocation_tracker.c

+5 −0

Original line number	Diff line number	Diff line
		@@ -167,6 +167,11 @@ void allocation_tracker_notify_free(UNUSED_ATTR uint8_t allocator_id, void ptr
		assert(end_canary[i] == canary[i]);
		}

		// Free the hash map entry to avoid unlimited memory usage growth.
		// Double-free of memory is detected with "assert(allocation)" above
		// as the allocation entry will not be present.
		hash_map_erase(allocations, ptr);

		pthread_mutex_unlock(&lock);

		return ((char *)ptr) - canary_size;