Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e752407b authored by Chiachang Wang's avatar Chiachang Wang
Browse files

Set last probing time to always evaluate stall 

isDataStall() will skip the stall check if NetworkMonitor sent
probe within the minimal evaluation time to prevent sending
probing too frequently. In differnent test targets, the probing
result may come back just before test tries to check wether
it's stall or not. It may result in the unexpected result.
Set the last probing time to always evaluate it since the test
does not try to exam that part.

Bug: 185082309
Test: atest NetworkMonitorTest in forrest for 20 sets
Change-Id: I52a215e9c5be2c0f069ca24f800d4d616bb437d8
parent 445e3816

tests/unit/src/com/android/server/connectivity/NetworkMonitorTest.java

+2 −0
Original line number Diff line number Diff line
@@ -2023,6 +2023,8 @@ public class NetworkMonitorTest { 
                ArgumentCaptor.forClass(DataStallDetectionStats.class);

        verify(mDependencies, timeout(HANDLER_TIMEOUT_MS).times(1))

                .writeDataStallDetectionStats(statsCaptor.capture(), probeResultCaptor.capture());

        // Ensure probe will not stop due to rate-limiting mechanism.

        nm.setLastProbeTime(SystemClock.elapsedRealtime() - 1000);

        assertTrue(nm.isDataStall());

        assertTrue(probeResultCaptor.getValue().isSuccessful());

        verifyTestDataStallDetectionStats(evalType, transport, statsCaptor.getValue());