Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b86f43cb authored by Chiachang Wang's avatar Chiachang Wang
Browse files

Annotate @RequiresApi for S to class level 

All the methods, except newInstance() in the api31 shim require
API 31. Annotate them for linter to clear judge it.

Bug: 186063555
Test: make NetworkStackApiCurrentShims
Change-Id: I7b537141405b48b04262a4a0bdf887bd58107761
parent 445e3816

Android.bp

+3 −0
Original line number Diff line number Diff line
@@ -69,6 +69,9 @@ java_defaults { 
        "androidx.annotation_annotation",

        "networkstack-client",

    ],

    static_libs : [

        "modules-utils-build_system"

    ],

    apex_available: [

        "com.android.tethering",

        "//apex_available:platform",  // For InProcessNetworkStack and InProcessTethering

apishim/31/com/android/networkstack/apishim/ConnectivityManagerShimImpl.java

+6 −2
Original line number Diff line number Diff line
@@ -16,6 +16,8 @@ 


package com.android.networkstack.apishim;



import static com.android.modules.utils.build.SdkLevel.isAtLeastS;



import android.content.Context;

import android.net.ConnectivityManager;

import android.net.ConnectivityManager.NetworkCallback;
@@ -25,15 +27,16 @@ import android.os.Handler; 
import android.util.Range;



import androidx.annotation.NonNull;

import androidx.annotation.RequiresApi;



import com.android.networkstack.apishim.common.ConnectivityManagerShim;

import com.android.networkstack.apishim.common.ShimUtils;



import java.util.Collection;



/**

 * Implementation of {@link ConnectivityManagerShim} for API 31.

 */

@RequiresApi(Build.VERSION_CODES.S)

public class ConnectivityManagerShimImpl

        extends com.android.networkstack.apishim.api30.ConnectivityManagerShimImpl  {

    private final ConnectivityManager mCm;
@@ -46,8 +49,9 @@ public class ConnectivityManagerShimImpl 
    /**

     * Get a new instance of {@link ConnectivityManagerShim}.

     */

    @RequiresApi(Build.VERSION_CODES.Q)

    public static ConnectivityManagerShim newInstance(Context context) {

        if (!ShimUtils.isReleaseOrDevelopmentApiAbove(Build.VERSION_CODES.R)) {

        if (!isAtLeastS()) {

            return com.android.networkstack.apishim.api30.ConnectivityManagerShimImpl

                    .newInstance(context);

        }

apishim/31/com/android/networkstack/apishim/NetworkRequestShimImpl.java

+6 −5
Original line number Diff line number Diff line
@@ -16,6 +16,8 @@ 


package com.android.networkstack.apishim;



import static com.android.modules.utils.build.SdkLevel.isAtLeastS;



import android.net.NetworkRequest;

import android.os.Build;

import android.util.Range;
@@ -25,13 +27,13 @@ import androidx.annotation.Nullable; 
import androidx.annotation.RequiresApi;



import com.android.networkstack.apishim.common.NetworkRequestShim;

import com.android.networkstack.apishim.common.ShimUtils;



import java.util.Set;



/**

 * Implementation of {@link NetworkRequestShim} for API 31.

 */

@RequiresApi(Build.VERSION_CODES.S)

public class NetworkRequestShimImpl

        extends com.android.networkstack.apishim.api30.NetworkRequestShimImpl {

    protected NetworkRequestShimImpl() {
@@ -41,10 +43,10 @@ public class NetworkRequestShimImpl 
    /**

     * Get a new instance of {@link NetworkRequestShim}.

     */

    @RequiresApi(Build.VERSION_CODES.Q)

    public static NetworkRequestShim newInstance() {

        if (!ShimUtils.isReleaseOrDevelopmentApiAbove(Build.VERSION_CODES.R)) {

            return com.android.networkstack.apishim.api30.NetworkRequestShimImpl

                    .newInstance();

        if (!isAtLeastS()) {

            return com.android.networkstack.apishim.api30.NetworkRequestShimImpl.newInstance();

        }

        return new NetworkRequestShimImpl();

    }
@@ -55,7 +57,6 @@ public class NetworkRequestShimImpl 
        builder.setUids(uids);

    }



    @RequiresApi(Build.VERSION_CODES.S)

    @Override

    public NetworkRequest.Builder newBuilder(@NonNull NetworkRequest request) {

        return new NetworkRequest.Builder(request);

jarjar-rules-shared.txt

+3 −0
Original line number Diff line number Diff line
@@ -11,3 +11,6 @@ rule android.net.DhcpResults* android.net.networkstack.DhcpResults@1 
rule android.util.LocalLog* android.net.networkstack.util.LocalLog@1



rule android.util.IndentingPrintWriter* android.net.networkstack.util.AndroidUtilIndentingPrintWriter@1



# Classes from modules-utils-build_system

rule com.android.modules.utils.build.** com.android.networkstack.utils.build.@1
 
 No newline at end of file