Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d11adb06 authored by Ken Chen's avatar Ken Chen
Browse files

[Code Health] Fix misc-const-correctness lint 

Resolve build warnings in aosp/2526839.

Test: m
Change-Id: Id1387e605be62d819fc3b5469ae45ba9fe878d92
parent 47936dd7

DnsProxyListener.cpp

+2 −2
Original line number Diff line number Diff line
@@ -459,7 +459,7 @@ void logDnsQueryResult(const addrinfo* res) { 
        // getnameinfo.

        const sockaddr* ai_addr = ai->ai_addr;

        char ip_addr[INET6_ADDRSTRLEN];

        int ret = getnameinfo(ai_addr, ai->ai_addrlen, ip_addr, sizeof(ip_addr), nullptr, 0,

        const int ret = getnameinfo(ai_addr, ai->ai_addrlen, ip_addr, sizeof(ip_addr), nullptr, 0,

                                    NI_NUMERICHOST);

        if (!ret) {

            LOG(DEBUG) << __func__ << ": [" << i << "] " << ai->ai_flags << " " << ai->ai_family

hostent.h

+1 −1
Original line number Diff line number Diff line
@@ -64,7 +64,7 @@ static const char NAT64_PAD[NS_IN6ADDRSZ - NS_INADDRSZ] = {}; 
    } while (0)



#define HENT_SCOPY(dst, src, ptr, len) do {  \

        size_t _len = strlen(src) + 1;       \

        const size_t _len = strlen(src) + 1; \

        HENT_COPY(dst, src, _len, ptr, len); \

    } while (0)

tests/resolv_test_utils.cpp

+4 −3
Original line number Diff line number Diff line
@@ -38,7 +38,8 @@ std::string ToString(const addrinfo* ai) { 


    const sockaddr* ai_addr = ai->ai_addr;

    char host[NI_MAXHOST];

    int rv = getnameinfo(ai_addr, ai->ai_addrlen, host, sizeof(host), nullptr, 0, NI_NUMERICHOST);

    const int rv =

            getnameinfo(ai_addr, ai->ai_addrlen, host, sizeof(host), nullptr, 0, NI_NUMERICHOST);

    if (rv != 0) return gai_strerror(rv);

    return host;

}
@@ -86,7 +87,7 @@ std::vector<std::string> ToStrings(const addrinfo* ai) { 
    for (const auto* aip = ai; aip != nullptr; aip = aip->ai_next) {

        const sockaddr* ai_addr = aip->ai_addr;

        char host[NI_MAXHOST];

        int rv = getnameinfo(ai_addr, aip->ai_addrlen, host, sizeof(host), nullptr, 0,

        const int rv = getnameinfo(ai_addr, aip->ai_addrlen, host, sizeof(host), nullptr, 0,

                                   NI_NUMERICHOST);

        if (rv != 0) {

            hosts.clear();