Commit a998b157 authored Nov 16, 2021 by Greg Kaiser

Fix file open check

fd.ok() returns a bool.  The NOT of that method will auto-cast to
a 0 or 1 as an int, and thus will never equal -1.  So our previous
check was always false.  We remove the int comparison to fix this.

Test: TreeHugger
Change-Id: I20ad5eae79622f680c5516df422a7fef7ff7966b

parent 1b2e16d6

tests/tun_forwarder.cpp

+1 −1

Original line number	Diff line number	Diff line
		@@ -143,7 +143,7 @@ bool TunForwarder::addForwardingRule(const std::array<std::string, 2>& from,

		unique_fd TunForwarder::createTun(const std::string& ifname) {
		unique_fd fd(open("/dev/tun", O_RDWR \| O_NONBLOCK \| O_CLOEXEC));
		if (!fd.ok() == -1) {
		if (!fd.ok()) {
		return {};
		}