Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9a185887 authored by Mike Yu's avatar Mike Yu
Browse files

Fix flaky test RepeatedSetup_KeepChangingPrivateDnsServers 

Same as aosp/1262819, this test needs a buffer time to prevent being
flaky. The test running time increases by 700ms as a side effect.

Bug: 150678049
Bug: 152371971
Test: resolv_integration_test passed
Change-Id: I603e2a3b6977bcac06b542bc5312305fe25487fb
parent baff6f88

tests/resolv_integration_test.cpp

+6 −0
Original line number Diff line number Diff line
@@ -4355,6 +4355,11 @@ TEST_F(ResolverTest, RepeatedSetup_KeepChangingPrivateDnsServers) { 
    enum TlsServerState { WORKING, UNSUPPORTED, UNRESPONSIVE };

    const std::string addr1 = getUniqueIPv4Address();

    const std::string addr2 = getUniqueIPv4Address();

    const auto waitForPrivateDnsStateUpdated = []() {

        // A buffer time for PrivateDnsConfiguration to update its state. It prevents this test

        // being flaky. See b/152009023 for the reason.

        std::this_thread::sleep_for(20ms);

    };



    test::DNSResponder dns1(addr1);

    test::DNSResponder dns2(addr2);
@@ -4408,6 +4413,7 @@ TEST_F(ResolverTest, RepeatedSetup_KeepChangingPrivateDnsServers) { 
            tls.setHangOnHandshakeForTesting(serverState == UNRESPONSIVE);

            const int connectCountsBefore = tls.acceptConnectionsCount();



            waitForPrivateDnsStateUpdated();

            ResolverParamsParcel parcel = DnsResponderClient::GetDefaultResolverParamsParcel();

            parcel.servers = {config.tlsServer};

            parcel.tlsServers = {config.tlsServer};