Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 450e0c5d authored by Mike Yu's avatar Mike Yu
Browse files

Test: Fix DnsResolverBinderTest.setLogSeverity to set correct default log severity 

To ease flaky tests debugging, change the test to set the log
severity to INFO on userdebug builds before the test finishes.

DnsResolver will print more logs when running the tests.
This is expected because DnsResolver's default log severity
on userdebug builds is INFO (see resolv_init).

Bug: N/A
Test: atest
Change-Id: I9c6c3b56f9af35e1a535f3269d6949aa794c60f6
parent b9868dfb

tests/dnsresolver_binder_test.cpp

+10 −3
Original line number Diff line number Diff line
@@ -37,6 +37,7 @@ 
#include <gtest/gtest.h>

#include <netdutils/Stopwatch.h>



#include <util.h>

#include "dns_metrics_listener/base_metrics_listener.h"

#include "dns_metrics_listener/test_metrics.h"

#include "unsolicited_listener/unsolicited_event_listener.h"
@@ -621,10 +622,16 @@ TEST_F(DnsResolverBinderTest, setLogSeverity) { 
    EXPECT_TRUE(mDnsResolver->setLogSeverity(IDnsResolver::DNS_RESOLVER_LOG_ERROR).isOk());

    mExpectedLogData.push_back({"setLogSeverity(4)", "setLogSeverity.*4"});



    // Set back to default

    // Set back to default based off resolv_init(), the default is INFO for userdebug builds

    // and is WARNING for the other builds.

    if (isUserDebugBuild()) {

        EXPECT_TRUE(mDnsResolver->setLogSeverity(IDnsResolver::DNS_RESOLVER_LOG_INFO).isOk());

        mExpectedLogData.push_back({"setLogSeverity(2)", "setLogSeverity.*2"});

    } else {

        EXPECT_TRUE(mDnsResolver->setLogSeverity(IDnsResolver::DNS_RESOLVER_LOG_WARNING).isOk());

        mExpectedLogData.push_back({"setLogSeverity(3)", "setLogSeverity.*3"});

    }

}



TEST_F(DnsResolverBinderTest, SetResolverOptions) {

    SKIP_IF_REMOTE_VERSION_LESS_THAN(mDnsResolver.get(), 9);