Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2556134b authored by Bernie Innocenti's avatar Bernie Innocenti
Browse files

Remove SO_REUSEPORT from DnsTlsFrontend 

It doesn't just let us "share" the port with another server, it also
load-balances connections, making things mysteriously flaky.

There's probably a race between on DnsTlsFrontend quitting and the next
one starting when multiple tests run... but this isn't the right fix.

Change-Id: I0221f2ca9424222b00a283ff5cbfabd0169bd616
parent 38a6f997

tests/dns_responder/dns_tls_frontend.cpp

+0 −1
Original line number Diff line number Diff line
@@ -114,7 +114,6 @@ bool DnsTlsFrontend::startServer() { 
            PLOG(INFO) << "ignore creating socket failed " << s.get();

            continue;

        }

        enableSockopt(s.get(), SOL_SOCKET, SO_REUSEPORT).ignoreError();

        enableSockopt(s.get(), SOL_SOCKET, SO_REUSEADDR).ignoreError();

        std::string host_str = addr2str(ai->ai_addr, ai->ai_addrlen);

        if (bind(s.get(), ai->ai_addr, ai->ai_addrlen)) {