Commit 23b1f138 authored Aug 21, 2020 by Stephen Hines

Fix tidy warnings for r399163 Clang update.

Fix tidy warnings signed char -> int conversions.

/disk/android_trees/aosp-master-plus-llvm/packages/modules/DnsResolver/res_comp.cpp:144:28: error: 'signed char' to 'int' conversion; consider casting to 'unsigned char' first. [cert-str34-c,-warnings-as-errors]
    int pch = PERIOD, ch = *dn++;
                           ^
/disk/android_trees/aosp-master-plus-llvm/packages/modules/DnsResolver/res_comp.cpp:147:19: error: 'signed char' to 'int' conversion; consider casting to 'unsigned char' first. [cert-str34-c,-warnings-as-errors]
        int nch = *dn++;
                  ^
/disk/android_trees/aosp-master-plus-llvm/packages/modules/DnsResolver/res_comp.cpp:168:18: error: 'signed char' to 'int' conversion; consider casting to 'unsigned char' first. [cert-str34-c,-warnings-as-errors]
    while ((ch = *dn++) != '\0')
                 ^

Fix tidy warnings for unused result by casting to void.

/disk/android_trees/aosp-master-plus-llvm/packages/modules/DnsResolver/tests/dns_responder/dns_tls_frontend.cpp:155:5: error: the value returned by this function should be used [bugprone-unused-return-value,-warnings-as-errors]
    connect(backend_socket_.get(), backend_ai_res->ai_addr, backend_ai_res->ai_addrlen);
    ^

Bug: http://b/155835175
Test: m

Change-Id: Iada74f5c50a563012bfd26cee9088a3a72371f56

parent 957333d2

res_comp.cpp

+3 −3

Original line number	Diff line number	Diff line
		@@ -141,10 +141,10 @@ int dn_skipname(const uint8_t* ptr, const uint8_t* eom) {
		#define domainchar(c) ((c) > 0x20 && (c) < 0x7f)

		bool res_hnok(const char* dn) {
		int pch = PERIOD, ch = *dn++;
		char pch = PERIOD, ch = *dn++;

		while (ch != '\0') {
		int nch = *dn++;
		char nch = *dn++;

		if (periodchar(ch)) {
		;
		@@ -163,7 +163,7 @@ bool res_hnok(const char* dn) {
		* recommendations.
		*/
		bool res_dnok(const char* dn) {
		int ch;
		char ch;

		while ((ch = *dn++) != '\0')
		if (!domainchar(ch)) return false;

tests/dns_responder/dns_tls_frontend.cpp

+2 −1

Original line number	Diff line number	Diff line
		@@ -152,7 +152,8 @@ bool DnsTlsFrontend::startServer() {

		// connect() always fails in the test DnsTlsSocketTest.SlowDestructor because of
		// no backend server. Don't check it.
		connect(backend_socket_.get(), backend_ai_res->ai_addr, backend_ai_res->ai_addrlen);
		static_cast<void>(
		connect(backend_socket_.get(), backend_ai_res->ai_addr, backend_ai_res->ai_addrlen));

		// Set up eventfd socket.
		event_fd_.reset(eventfd(0, EFD_NONBLOCK \| EFD_CLOEXEC));