Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1f663fc2 authored by Mike Yu's avatar Mike Yu
Browse files

Remove dead code in PrivateDnsConfiguration 

No functionality changes.

Bug: 186177613
Test: None, just remove some dead code
Change-Id: I1676de854997ee984ef7395974ae64c3f9b685ab
parent 453b5e4e

DnsTlsDispatcher.cpp

+1 −2
Original line number Diff line number Diff line
@@ -242,8 +242,7 @@ DnsTlsTransport::Result DnsTlsDispatcher::queryInternal(Transport& xport, 


    const auto status = res.wait_for(xport.timeout());

    if (status == std::future_status::timeout) {

        // TODO: notify the Transport to remove the query because no queries will await this future.

        // b/186613628.

        // TODO(b/186613628): notify the Transport to remove this query.

        LOG(WARNING) << "DoT query timed out after " << xport.timeout().count() << " ms";

        return DnsTlsTransport::Result{

                .code = DnsTlsTransport::Response::network_error,

PrivateDnsConfiguration.cpp

+0 −2
Original line number Diff line number Diff line
@@ -308,8 +308,6 @@ bool PrivateDnsConfiguration::recordPrivateDnsValidation(const DnsTlsServer& ser 
        success = false;

        reevaluationStatus = DONT_REEVALUATE;

    } else if (!(serverPair->second == server)) {

        // TODO: It doesn't seem correct to overwrite the tracker entry for

        // |server| down below in this circumstance... Fix this.

        LOG(WARNING) << "Server " << server.toIpString()

                     << " was changed during private DNS validation";

        success = false;

PrivateDnsConfiguration.h

+0 −1
Original line number Diff line number Diff line
@@ -92,7 +92,6 @@ class PrivateDnsConfiguration { 


  private:

    typedef std::map<ServerIdentity, DnsTlsServer> PrivateDnsTracker;

    typedef std::set<DnsTlsServer, AddressComparator> ThreadTracker;



    PrivateDnsConfiguration() = default;