Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 17311bed authored by Hungming Chen's avatar Hungming Chen Committed by Nucca Chen
Browse files

getaddrinfo: initialize addrinfo_sort_elem array to zero 

resolv_rfc6724_sort() may not initialize the data member "src_addr"
of sort element while _find_src_addr() failed. Uninitialized "src_addr"
may cause unexpected rfc6724 sort result. Ex: _get_scope() uses
"src_addr" to compare sort element in _rfc6724_compare().

Test: atest ResolverTest
Bug: 247939181
Change-Id: I8d37cc127bdcac9b8092b45e1be6fe069999282a
parent 41ac1de3

getaddrinfo.cpp

+1 −1
Original line number Diff line number Diff line
@@ -1340,7 +1340,7 @@ void resolv_rfc6724_sort(struct addrinfo* list_sentinel, unsigned mark, uid_t ui 
        cur = cur->ai_next;

    }



    elems = (struct addrinfo_sort_elem*) malloc(nelem * sizeof(struct addrinfo_sort_elem));

    elems = (struct addrinfo_sort_elem*) calloc(nelem, sizeof(struct addrinfo_sort_elem));

    if (elems == NULL) {

        goto error;

    }