Snap for 11028996 from 2b8e125a74503cdb44aac3fd011d4c4acfc02d20 to mainline-permission-release (0a19ce63) · Commits · e / os / android_packages_modules_DnsResolver

Android.bp

+56 −15

Original line number	Diff line number	Diff line
		@@ -96,22 +96,63 @@ aidl_interface {
		min_sdk_version: "30",
		},
		},
		versions: [
		"1",
		"2",
		"3",
		"4",
		"5",
		"6",
		"7",
		"8",
		"9",
		"10",
		"11",
		],

		dumpapi: {
		no_license: true,
		},
		versions_with_info: [
		{
		version: "1",
		imports: ["netd_event_listener_interface-V1"],
		},
		{
		version: "2",
		imports: ["netd_event_listener_interface-V1"],
		},
		{
		version: "3",
		imports: ["netd_event_listener_interface-V1"],
		},
		{
		version: "4",
		imports: ["netd_event_listener_interface-V1"],
		},
		{
		version: "5",
		imports: ["netd_event_listener_interface-V1"],
		},
		{
		version: "6",
		imports: ["netd_event_listener_interface-V1"],
		},
		{
		version: "7",
		imports: ["netd_event_listener_interface-V1"],
		},
		{
		version: "8",
		imports: ["netd_event_listener_interface-V1"],
		},
		{
		version: "9",
		imports: ["netd_event_listener_interface-V1"],
		},
		{
		version: "10",
		imports: ["netd_event_listener_interface-V1"],
		},
		{
		version: "11",
		imports: ["netd_event_listener_interface-V1"],
		},
		{
		version: "12",
		imports: ["netd_event_listener_interface-V1"],
		},

		],
		frozen: true,

		}

		cc_defaults {
		@@ -154,7 +195,7 @@ cc_defaults {
		// after the build process.
		host_required: [
		"net-tests-utils-host-common",
		]
		],
		}

		cc_defaults {
		@@ -176,7 +217,7 @@ cc_defaults {
		// after the build process.
		host_required: [
		"net-tests-utils-host-common",
		]
		],
		}

		cc_library {

DnsProxyListener.cpp

+34 −54

Original line number	Diff line number	Diff line
		@@ -818,23 +818,16 @@ void DnsProxyListener::GetAddrInfoHandler::doDns64Synthesis(int32_t* rv, addrinf

		if (ipv6WantedButNoData) {
		// If caller wants IPv6 answers but no data, try to query IPv4 answers for synthesis
		const uid_t uid = mClient->getUid();
		if (startQueryLimiter(uid)) {
		const char* host = mHost.starts_with('^') ? nullptr : mHost.c_str();
		const char* service = mService.starts_with('^') ? nullptr : mService.c_str();
		mHints->ai_family = AF_INET;
		// Don't need to do freeaddrinfo(res) before starting new DNS lookup because previous
		// DNS lookup is failed with error EAI_NODATA.
		*rv = resolv_getaddrinfo(host, service, mHints.get(), &mNetContext, res, event);
		endQueryLimiter(uid);
		if (*rv) {
		*rv = EAI_NODATA; // return original error code
		return;
		}
		} else {
		LOG(ERROR) << __func__ << ": from UID " << uid << ", max concurrent queries reached";
		return;
		}
		}

		if (!synthesizeNat64PrefixWithARecord(prefix, res, unspecWantedButNoIPv6, &mNetContext)) {
		@@ -865,6 +858,7 @@ void DnsProxyListener::GetAddrInfoHandler::run() {
		const char* service = mService.starts_with('^') ? nullptr : mService.c_str();
		if (evaluate_domain_name(mNetContext, host)) {
		rv = resolv_getaddrinfo(host, service, mHints.get(), &mNetContext, &result, &event);
		doDns64Synthesis(&rv, &result, &event);
		} else {
		rv = EAI_SYSTEM;
		}
		@@ -877,7 +871,6 @@ void DnsProxyListener::GetAddrInfoHandler::run() {
		<< ", max concurrent queries reached";
		}

		doDns64Synthesis(&rv, &result, &event);
		const int32_t latencyUs = saturate_cast<int32_t>(s.timeTakenUs());
		event.set_latency_micros(latencyUs);
		event.set_event_type(EVENT_GETADDRINFO);
		@@ -1055,8 +1048,8 @@ void DnsProxyListener::ResNSendHandler::run() {
		uint16_t original_query_id = 0;

		// TODO: Handle the case which is msg contains more than one query
		if (!parseQuery({msg.data(), msgLen}, &original_query_id, &rr_type, &rr_name) \|\|
		!setQueryId({msg.data(), msgLen}, arc4random_uniform(65536))) {
		if (!parseQuery(std::span(msg.data(), msgLen), &original_query_id, &rr_type, &rr_name) \|\|
		!setQueryId(std::span(msg.data(), msgLen), arc4random_uniform(65536))) {
		// If the query couldn't be parsed, block the request.
		LOG(WARNING) << "ResNSendHandler::run: resnsend: from UID " << uid << ", invalid query";
		sendBE32(mClient, -EINVAL);
		@@ -1071,7 +1064,7 @@ void DnsProxyListener::ResNSendHandler::run() {
		initDnsEvent(&event, mNetContext);
		if (startQueryLimiter(uid)) {
		if (evaluate_domain_name(mNetContext, rr_name.c_str())) {
		ansLen = resolv_res_nsend(&mNetContext, {msg.data(), msgLen}, ansBuf, &rcode,
		ansLen = resolv_res_nsend(&mNetContext, std::span(msg.data(), msgLen), ansBuf, &rcode,
		static_cast<ResNsendFlags>(mFlags), &event);
		} else {
		ansLen = -EAI_SYSTEM;
		@@ -1109,7 +1102,7 @@ void DnsProxyListener::ResNSendHandler::run() {
		}

		// Restore query id
		if (!setQueryId({ansBuf.data(), ansLen}, original_query_id)) {
		if (!setQueryId(std::span(ansBuf.data(), ansLen), original_query_id)) {
		LOG(WARNING) << "ResNSendHandler::run: resnsend: failed to restore query id";
		return;
		}
		@@ -1124,7 +1117,7 @@ void DnsProxyListener::ResNSendHandler::run() {
		if (rr_type == ns_t_a \|\| rr_type == ns_t_aaaa) {
		std::vector<std::string> ip_addrs;
		const int total_ip_addr_count =
		extractResNsendAnswers({ansBuf.data(), ansLen}, rr_type, &ip_addrs);
		extractResNsendAnswers(std::span(ansBuf.data(), ansLen), rr_type, &ip_addrs);
		reportDnsEvent(INetdEventListener::EVENT_RES_NSEND, mNetContext, latencyUs,
		resNSendToAiError(ansLen, rcode), event, rr_name, ip_addrs,
		total_ip_addr_count);
		@@ -1244,19 +1237,12 @@ void DnsProxyListener::GetHostByNameHandler::doDns64Synthesis(int32_t* rv, hoste
		}

		// If caller wants IPv6 answers but no data, try to query IPv4 answers for synthesis
		const uid_t uid = mClient->getUid();
		if (startQueryLimiter(uid)) {
		const char* name = mName.starts_with('^') ? nullptr : mName.c_str();
		*rv = resolv_gethostbyname(name, AF_INET, hbuf, buf, buflen, &mNetContext, hpp, event);
		endQueryLimiter(uid);
		if (*rv) {
		*rv = EAI_NODATA; // return original error code
		return;
		}
		} else {
		LOG(ERROR) << __func__ << ": from UID " << uid << ", max concurrent queries reached";
		return;
		}

		if (!synthesizeNat64PrefixWithARecord(prefix, *hpp)) {
		// If caller wants IPv6 answers but no data and failed to synthesize IPv4 answers,
		@@ -1281,6 +1267,7 @@ void DnsProxyListener::GetHostByNameHandler::run() {
		if (evaluate_domain_name(mNetContext, name)) {
		rv = resolv_gethostbyname(name, mAf, &hbuf, tmpbuf, sizeof tmpbuf, &mNetContext, &hp,
		&event);
		doDns64Synthesis(&rv, &hbuf, tmpbuf, sizeof tmpbuf, &hp, &event);
		} else {
		rv = EAI_SYSTEM;
		}
		@@ -1291,7 +1278,6 @@ void DnsProxyListener::GetHostByNameHandler::run() {
		<< ", max concurrent queries reached";
		}

		doDns64Synthesis(&rv, &hbuf, tmpbuf, sizeof tmpbuf, &hp, &event);
		const int32_t latencyUs = saturate_cast<int32_t>(s.timeTakenUs());
		event.set_latency_micros(latencyUs);
		event.set_event_type(EVENT_GETHOSTBYNAME);
		@@ -1406,13 +1392,10 @@ void DnsProxyListener::GetHostByAddrHandler::doDns64ReverseLookup(hostent* hbuf,
		return;
		}

		const uid_t uid = mClient->getUid();
		if (startQueryLimiter(uid)) {
		// Remove NAT64 prefix and do reverse DNS query
		struct in_addr v4addr = {.s_addr = v6addr.s6_addr32[3]};
		resolv_gethostbyaddr(&v4addr, sizeof(v4addr), AF_INET, hbuf, buf, buflen, &mNetContext, hpp,
		event);
		endQueryLimiter(uid);
		if (hpp && (hpp)->h_addr_list[0]) {
		// Replace IPv4 address with original queried IPv6 address in place. The space has
		// reserved by dns_gethtbyaddr() and netbsd_gethostent_r() in
		@@ -1425,9 +1408,6 @@ void DnsProxyListener::GetHostByAddrHandler::doDns64ReverseLookup(hostent* hbuf,
		} else {
		LOG(ERROR) << __func__ << ": hpp or (*hpp)->h_addr_list[0] is null";
		}
		} else {
		LOG(ERROR) << __func__ << ": from UID " << uid << ", max concurrent queries reached";
		}
		}

		void DnsProxyListener::GetHostByAddrHandler::run() {
		@@ -1453,6 +1433,7 @@ void DnsProxyListener::GetHostByAddrHandler::run() {
		} else {
		rv = resolv_gethostbyaddr(&mAddress, mAddressLen, mAddressFamily, &hbuf, tmpbuf,
		sizeof tmpbuf, &mNetContext, &hp, &event);
		doDns64ReverseLookup(&hbuf, tmpbuf, sizeof tmpbuf, &hp, &event);
		}
		endQueryLimiter(uid);
		} else {
		@@ -1461,7 +1442,6 @@ void DnsProxyListener::GetHostByAddrHandler::run() {
		<< ", max concurrent queries reached";
		}

		doDns64ReverseLookup(&hbuf, tmpbuf, sizeof tmpbuf, &hp, &event);
		const int32_t latencyUs = saturate_cast<int32_t>(s.timeTakenUs());
		event.set_latency_micros(latencyUs);
		event.set_event_type(EVENT_GETHOSTBYADDR);

DnsTlsTransport.cpp

+1 −1

Original line number	Diff line number	Diff line
		@@ -113,7 +113,7 @@ base::Result<void> sendUdpQuery(netdutils::IPAddress ip, uint32_t mark,
		return ErrnoErrorf("connect failed");
		}

		if (send(fd, query.data(), query.size(), 0) != query.size()) {
		if (send(fd, query.data(), query.size(), 0) != static_cast<ptrdiff_t>(query.size())) {
		return ErrnoErrorf("send failed");
		}

ResolverController.cpp

+2 −7

Original line number	Diff line number	Diff line
		@@ -37,9 +37,11 @@
		#include "stats.h"
		#include "util.h"

		using aidl::android::net::IDnsResolver;
		using aidl::android::net::ResolverParamsParcel;
		using aidl::android::net::resolv::aidl::IDnsResolverUnsolicitedEventListener;
		using aidl::android::net::resolv::aidl::Nat64PrefixEventParcel;
		using android::net::ResolverStats;

		namespace android {

		@@ -79,8 +81,6 @@ void sendNat64PrefixEvent(const Dns64Configuration::Nat64PrefixInfo& args) {
		int getDnsInfo(unsigned netId, std::vector<std::string>* servers, std::vector<std::string>* domains,
		res_params* params, std::vector<android::net::ResolverStats>* stats,
		int* wait_for_pending_req_timeout_count) {
		using aidl::android::net::IDnsResolver;
		using android::net::ResolverStats;
		static_assert(ResolverStats::STATS_SUCCESSES == IDnsResolver::RESOLVER_STATS_SUCCESSES &&
		ResolverStats::STATS_ERRORS == IDnsResolver::RESOLVER_STATS_ERRORS &&
		ResolverStats::STATS_TIMEOUTS == IDnsResolver::RESOLVER_STATS_TIMEOUTS &&
		@@ -192,8 +192,6 @@ int ResolverController::flushNetworkCache(unsigned netId) {
		}

		int ResolverController::setResolverConfiguration(const ResolverParamsParcel& resolverParams) {
		using aidl::android::net::IDnsResolver;

		if (!has_named_cache(resolverParams.netId)) {
		return -ENOENT;
		}
		@@ -247,8 +245,6 @@ int ResolverController::getResolverInfo(int32_t netId, std::vector<std::string>*
		std::vector<std::string>* tlsServers,
		std::vector<int32_t>* params, std::vector<int32_t>* stats,
		int* wait_for_pending_req_timeout_count) {
		using aidl::android::net::IDnsResolver;
		using android::net::ResolverStats;
		res_params res_params;
		std::vector<ResolverStats> res_stats;
		int ret = getDnsInfo(netId, servers, domains, &res_params, &res_stats,
		@@ -295,7 +291,6 @@ int ResolverController::getPrefix64(unsigned netId, netdutils::IPPrefix* prefix)

		void ResolverController::dump(DumpWriter& dw, unsigned netId) {
		// No lock needed since Bionic's resolver locks all accessed data structures internally.
		using android::net::ResolverStats;
		std::vector<std::string> servers;
		std::vector<std::string> domains;
		res_params params = {};

aidl_api/dnsresolver_aidl_interface/12/.hash

0 → 100644

+1 −0

Original line number	Diff line number	Diff line
		a65a6755e2e5f5c160e7be2be814019e2d5491b1