From 4c9cef67d8ebe5562006eb6b65e3a452f25881c1 Mon Sep 17 00:00:00 2001 From: Fahim Date: Tue, 4 Jan 2022 08:16:58 +0600 Subject: [PATCH] 4513-P-Revert_to_old_color_schemes issue: https://gitlab.e.foundation/e/backlog/-/issues/4513 --- .../bg_btn_keyboard_key_normal_off.xml | 25 ----- .../bg_btn_keyboard_key_normal_on.xml | 25 ----- java/res/drawable/btn_keyboard_key_ics.xml | 8 +- java/res/drawable/btn_keyboard_key_klp.xml | 8 +- .../drawable/btn_keyboard_key_lxx_dark.xml | 8 +- .../drawable/btn_keyboard_key_lxx_light.xml | 8 +- java/res/drawable/ic_add_circle.xml | 2 +- java/res/values-night-v28/platform-theme.xml | 36 ------- .../bools.xml} | 16 +-- java/res/values-v28/platform-theme.xml | 36 ------- java/res/values/bools.xml | 2 + java/res/values/colors.xml | 98 +++++++++---------- java/res/values/platform-theme.xml | 8 +- java/res/values/themes-ics.xml | 12 +-- java/res/values/themes-klp.xml | 12 +-- java/res/values/themes-lxx-dark.xml | 12 +-- java/res/values/themes-lxx-light.xml | 12 +-- .../inputmethod/keyboard/KeyboardTheme.java | 6 +- .../keyboard/internal/KeyPreviewView.java | 1 - .../UserDictionaryAddWordFragment.java | 2 - 20 files changed, 107 insertions(+), 230 deletions(-) delete mode 100644 java/res/drawable/bg_btn_keyboard_key_normal_off.xml delete mode 100644 java/res/drawable/bg_btn_keyboard_key_normal_on.xml delete mode 100644 java/res/values-night-v28/platform-theme.xml rename java/res/{drawable/ic_arrow_back.xml => values-night/bools.xml} (58%) delete mode 100644 java/res/values-v28/platform-theme.xml diff --git a/java/res/drawable/bg_btn_keyboard_key_normal_off.xml b/java/res/drawable/bg_btn_keyboard_key_normal_off.xml deleted file mode 100644 index 1def20b12e..0000000000 --- a/java/res/drawable/bg_btn_keyboard_key_normal_off.xml +++ /dev/null @@ -1,25 +0,0 @@ - - - - - - diff --git a/java/res/drawable/bg_btn_keyboard_key_normal_on.xml b/java/res/drawable/bg_btn_keyboard_key_normal_on.xml deleted file mode 100644 index 135c1d5434..0000000000 --- a/java/res/drawable/bg_btn_keyboard_key_normal_on.xml +++ /dev/null @@ -1,25 +0,0 @@ - - - - - - \ No newline at end of file diff --git a/java/res/drawable/btn_keyboard_key_ics.xml b/java/res/drawable/btn_keyboard_key_ics.xml index 67fe833458..bacd5d78ff 100644 --- a/java/res/drawable/btn_keyboard_key_ics.xml +++ b/java/res/drawable/btn_keyboard_key_ics.xml @@ -23,13 +23,13 @@ + android:drawable="@drawable/btn_keyboard_key_pressed_on_ics_dark" /> + android:drawable="@drawable/btn_keyboard_key_pressed_off_ics_dark" /> + android:drawable="@drawable/btn_keyboard_key_normal_on_ics_dark" /> + android:drawable="@drawable/btn_keyboard_key_normal_off_holo_dark" /> + android:drawable="@drawable/btn_keyboard_key_pressed_on_klp_dark" /> + android:drawable="@drawable/btn_keyboard_key_pressed_off_klp_dark" /> + android:drawable="@drawable/btn_keyboard_key_normal_on_klp_dark" /> + android:drawable="@drawable/btn_keyboard_key_normal_off_holo_dark" /> + android:drawable="@drawable/btn_keyboard_key_pressed_on_lxx_dark" /> + android:drawable="@drawable/btn_keyboard_key_pressed_off_lxx_dark" /> + android:drawable="@drawable/btn_keyboard_key_normal_on_lxx_dark" /> + android:drawable="@drawable/btn_keyboard_key_normal_off_lxx_dark" /> + android:drawable="@drawable/btn_keyboard_key_pressed_on_lxx_light" /> + android:drawable="@drawable/btn_keyboard_key_pressed_off_lxx_light" /> + android:drawable="@drawable/btn_keyboard_key_normal_on_lxx_light" /> + android:drawable="@drawable/btn_keyboard_key_normal_off_lxx_light" /> \ No newline at end of file diff --git a/java/res/values-night-v28/platform-theme.xml b/java/res/values-night-v28/platform-theme.xml deleted file mode 100644 index 349ad73de9..0000000000 --- a/java/res/values-night-v28/platform-theme.xml +++ /dev/null @@ -1,36 +0,0 @@ - - - - - - - diff --git a/java/res/drawable/ic_arrow_back.xml b/java/res/values-night/bools.xml similarity index 58% rename from java/res/drawable/ic_arrow_back.xml rename to java/res/values-night/bools.xml index a1b4f1a80c..bffe6ee0ed 100644 --- a/java/res/drawable/ic_arrow_back.xml +++ b/java/res/values-night/bools.xml @@ -2,7 +2,7 @@ - - - - \ No newline at end of file + + false + diff --git a/java/res/values-v28/platform-theme.xml b/java/res/values-v28/platform-theme.xml deleted file mode 100644 index 4fd23ab0b9..0000000000 --- a/java/res/values-v28/platform-theme.xml +++ /dev/null @@ -1,36 +0,0 @@ - - - - - - - diff --git a/java/res/values/bools.xml b/java/res/values/bools.xml index 10d217985a..4689790515 100644 --- a/java/res/values/bools.xml +++ b/java/res/values/bools.xml @@ -21,4 +21,6 @@ false + + true diff --git a/java/res/values/colors.xml b/java/res/values/colors.xml index fc5e987485..352ecd7d3c 100644 --- a/java/res/values/colors.xml +++ b/java/res/values/colors.xml @@ -30,61 +30,61 @@ @lineageos.platform:color/color_default_view_on_accent - @color/color_default_accent - @color/color_default_accent - @color/color_default_primary_text - @color/color_default_secondary_text - @color/color_default_primary_text - @color/color_default_secondary_text - @color/color_default_secondary_text - @color/color_default_foreground - @color/color_default_secondary_text - @color/color_default_primary_text - @color/color_default_secondary_text + #FF33B5E5 + #D833B5E5 + #B233B5E5 + #9933B5E5 + @android:color/white + #66E0E4E5 + #80000000 + #A0FFFFFF + #66E0E4E5 + @android:color/white + #FFC0C0C0 #80000000 - @color/color_default_primary_dark - @color/color_default_foreground + #C0000000 + #111111 - @color/color_default_accent - @color/color_default_accent - @color/color_default_primary_text - @color/color_default_secondary_text + #FFF0F0F0 + #D8F0F0F0 + #B2F0F0F0 + #99E0E0E0 - @color/color_default_primary_text - @color/color_default_primary_text - @color/color_default_secondary_text - @color/color_default_secondary_text - @color/color_default_secondary_text - @color/color_default_accent - @color/color_default_primary_text - @color/color_default_accent - @color/color_default_primary_text - @color/color_default_accent - @color/color_default_accent - @color/color_default_foreground - @color/color_default_primary_dark - @color/color_default_primary_dark - @color/color_default_primary_dark - @color/color_default_foreground + #37474F + #CC37474F + #B337474F + #B337474F + #B337474F + @lineageos.platform:color/color_default_accent + #37474F + #D937474F + #B337474F + @lineageos.platform:color/color_default_accent + @lineageos.platform:color/color_default_accent + #ECEFF1 + #2637474F + #2637474F + #E6ECEFF1 + #E4E7E9 - @color/color_default_primary_text - @color/color_default_primary_text - @color/color_default_secondary_text - @color/color_default_secondary_text - @color/color_default_secondary_text - @color/color_default_accent - @color/color_default_primary_text - @color/color_default_accent - @color/color_default_primary_text - @color/color_default_accent - @color/color_default_accent - @color/color_default_foreground - @color/color_default_primary_dark - @color/color_default_primary_dark - @color/color_default_primary_dark - @color/color_default_foreground + #CCFFFFFF + #CCFFFFFF + #80FFFFFF + #80FFFFFF + #B3FFFFFF + @lineageos.platform:color/color_default_accent + #FFFFFF + #D9FFFFFF + #B3FFFFFF + @lineageos.platform:color/color_default_accent + @lineageos.platform:color/color_default_accent + #263238 + #19FFFFFF + #19FFFFFF + #E621272B + #21272B @color/color_default_background @color/color_default_primary_text diff --git a/java/res/values/platform-theme.xml b/java/res/values/platform-theme.xml index 7d23060f03..5fbde0b899 100644 --- a/java/res/values/platform-theme.xml +++ b/java/res/values/platform-theme.xml @@ -35,9 +35,15 @@ @color/color_default_primary_text @color/color_default_secondary_text - @drawable/ic_arrow_back + @lineageos.platform:drawable/ic_back @style/platformDialogTheme @color/color_default_primary_text + + @color/color_default_primary_dark + @color/color_default_primary_dark + true + @bool/is_in_light_mode + @bool/is_in_light_mode diff --git a/java/res/values/themes-klp.xml b/java/res/values/themes-klp.xml index b7c3ec2b5d..32884dba01 100644 --- a/java/res/values/themes-klp.xml +++ b/java/res/values/themes-klp.xml @@ -43,7 +43,7 @@ name="KeyboardView.KLP" parent="KeyboardView.Holo" > - @color/color_default_foreground + @drawable/keyboard_background_holo @drawable/btn_keyboard_key_klp @drawable/btn_keyboard_key_functional_klp @drawable/btn_keyboard_spacebar_klp @@ -54,7 +54,7 @@ @color/key_hint_label_color_holo @color/key_shifted_letter_hint_inactivated_color_holo @color/key_shifted_letter_hint_activated_color_holo - @color/color_default_view_on_accent + @color/key_text_color_holo diff --git a/java/res/values/themes-lxx-dark.xml b/java/res/values/themes-lxx-dark.xml index 3c175ccf4a..cae1f72438 100644 --- a/java/res/values/themes-lxx-dark.xml +++ b/java/res/values/themes-lxx-dark.xml @@ -42,7 +42,7 @@ name="KeyboardView.LXX_Dark" parent="KeyboardView.LXX" > - @color/color_default_foreground + @drawable/keyboard_background_lxx_dark @drawable/btn_keyboard_key_lxx_dark @drawable/btn_keyboard_key_functional_lxx_dark @drawable/btn_keyboard_spacebar_lxx_dark @@ -53,7 +53,7 @@ @color/key_text_inactive_color_lxx_dark @color/key_text_inactive_color_lxx_dark @color/key_text_color_lxx_dark - @color/color_default_view_on_accent + @color/key_text_color_lxx_dark diff --git a/java/res/values/themes-lxx-light.xml b/java/res/values/themes-lxx-light.xml index 924e08c6a9..eecd191a34 100644 --- a/java/res/values/themes-lxx-light.xml +++ b/java/res/values/themes-lxx-light.xml @@ -42,7 +42,7 @@ name="KeyboardView.LXX_Light" parent="KeyboardView.LXX" > - @color/color_default_foreground + @drawable/keyboard_background_lxx_light @drawable/btn_keyboard_key_lxx_light @drawable/btn_keyboard_key_functional_lxx_light @drawable/btn_keyboard_spacebar_lxx_light @@ -53,7 +53,7 @@ @color/key_text_inactive_color_lxx_light @color/key_text_inactive_color_lxx_light @color/key_text_color_lxx_light - @color/color_default_view_on_accent + @color/key_text_color_lxx_light diff --git a/java/src/com/android/inputmethod/keyboard/KeyboardTheme.java b/java/src/com/android/inputmethod/keyboard/KeyboardTheme.java index aa6c919b94..f92215db5f 100644 --- a/java/src/com/android/inputmethod/keyboard/KeyboardTheme.java +++ b/java/src/com/android/inputmethod/keyboard/KeyboardTheme.java @@ -30,6 +30,8 @@ import com.android.inputmethod.latin.R; import java.util.ArrayList; import java.util.Arrays; +import android.content.res.Configuration; + public final class KeyboardTheme implements Comparable { private static final String TAG = KeyboardTheme.class.getSimpleName(); @@ -212,9 +214,9 @@ public final class KeyboardTheme implements Comparable { if (theme != null) { return theme; } - Log.w(TAG, "Unknown keyboard theme in LXX preference: "); + Log.w(TAG, "Unknown keyboard theme in LXX preference."); } catch (final NumberFormatException e) { - Log.w(TAG, "Illegal keyboard theme in LXX preference: ", e); + Log.w(TAG, "Illegal keyboard theme in LXX preference.", e); } // Remove preference that contains unknown or illegal theme id. prefs.edit().remove(LXX_KEYBOARD_THEME_KEY).apply(); diff --git a/java/src/com/android/inputmethod/keyboard/internal/KeyPreviewView.java b/java/src/com/android/inputmethod/keyboard/internal/KeyPreviewView.java index 73935d262d..24538605a4 100644 --- a/java/src/com/android/inputmethod/keyboard/internal/KeyPreviewView.java +++ b/java/src/com/android/inputmethod/keyboard/internal/KeyPreviewView.java @@ -82,7 +82,6 @@ public class KeyPreviewView extends TextView { return; } background.getPadding(mBackgroundPadding); - background.setTint(R.color.color_default_primary_dark); final int maxWidth = background.getIntrinsicWidth() - mBackgroundPadding.left - mBackgroundPadding.right; final float width = getTextWidth(text, getPaint()); diff --git a/java/src/com/android/inputmethod/latin/userdictionary/UserDictionaryAddWordFragment.java b/java/src/com/android/inputmethod/latin/userdictionary/UserDictionaryAddWordFragment.java index 5780f1e290..aabf77adae 100644 --- a/java/src/com/android/inputmethod/latin/userdictionary/UserDictionaryAddWordFragment.java +++ b/java/src/com/android/inputmethod/latin/userdictionary/UserDictionaryAddWordFragment.java @@ -36,8 +36,6 @@ import android.widget.Spinner; import java.util.ArrayList; import java.util.Locale; -import com.android.inputmethod.latin.R; - // Caveat: This class is basically taken from // packages/apps/Settings/src/com/android/settings/inputmethod/UserDictionaryAddWordFragment.java // in order to deal with some devices that have issues with the user dictionary handling -- GitLab