Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f960eb18 authored by Jean Chalard's avatar Jean Chalard
Browse files

Don't put spaces after characters that don't take one 

Bug: 7393639
Change-Id: I1245a7b5077e554642838d6856ce269ca7f91988
parent 65225d82

java/src/com/android/inputmethod/latin/LatinIME.java

+5 −1
Original line number Diff line number Diff line
@@ -1431,8 +1431,12 @@ public final class LatinIME extends InputMethodService implements KeyboardAction 
            mSpaceState = SPACE_STATE_PHANTOM;

        } else {

            final int codePointBeforeCursor = mConnection.getCodePointBeforeCursor();

            // TODO: reverse this logic. We should have the means to determine whether a character

            // should usually be followed by a space, and it should be more readable.

            if (Constants.NOT_A_CODE != codePointBeforeCursor

                    && !Character.isWhitespace(codePointBeforeCursor)) {

                    && !Character.isWhitespace(codePointBeforeCursor)

                    && !mCurrentSettings.isPhantomSpacePromotingSymbol(codePointBeforeCursor)

                    && !mCurrentSettings.isWeakSpaceStripper(codePointBeforeCursor)) {

                mSpaceState = SPACE_STATE_PHANTOM;

            }

        }

java/src/com/android/inputmethod/latin/SettingsValues.java

+2 −0
Original line number Diff line number Diff line
@@ -254,11 +254,13 @@ public final class SettingsValues { 
        return mSymbolsExcludedFromWordSeparators.contains(String.valueOf((char)code));

    }



    // TODO: use "Phantom" instead of "Weak" in this method name

    public boolean isWeakSpaceStripper(final int code) {

        // TODO: this does not work if the code does not fit in a char

        return mWeakSpaceStrippers.contains(String.valueOf((char)code));

    }



    // TODO: use "Phantom" instead of "Weak" in this method name

    public boolean isWeakSpaceSwapper(final int code) {

        // TODO: this does not work if the code does not fit in a char

        return mWeakSpaceSwappers.contains(String.valueOf((char)code));