Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f74ddfbb authored by Ken Wakasa's avatar Ken Wakasa Committed by Android (Google) Code Review
Browse files

Merge "[Refactor] Divide BinaryDictInputOutput into BinaryDictInputUtils and... 

Merge "[Refactor] Divide BinaryDictInputOutput into BinaryDictInputUtils and BinaryDictOutputUtils."
parents a38a15dd 4c63d061

java/src/com/android/inputmethod/latin/BinaryDictionaryGetter.java

+4 −4
Original line number Diff line number Diff line
@@ -21,7 +21,7 @@ import android.content.SharedPreferences; 
import android.content.res.AssetFileDescriptor;

import android.util.Log;



import com.android.inputmethod.latin.makedict.BinaryDictInputOutput;

import com.android.inputmethod.latin.makedict.BinaryDictInputUtils;

import com.android.inputmethod.latin.makedict.FormatSpec;

import com.android.inputmethod.latin.utils.CollectionUtils;

import com.android.inputmethod.latin.utils.DictionaryInfoUtils;
@@ -231,8 +231,8 @@ final public class BinaryDictionaryGetter { 
        try {

            // Read the version of the file

            inStream = new FileInputStream(f);

            final BinaryDictInputOutput.ByteBufferWrapper buffer =

                    new BinaryDictInputOutput.ByteBufferWrapper(inStream.getChannel().map(

            final BinaryDictInputUtils.ByteBufferWrapper buffer =

                    new BinaryDictInputUtils.ByteBufferWrapper(inStream.getChannel().map(

                            FileChannel.MapMode.READ_ONLY, 0, f.length()));

            final int magic = buffer.readInt();

            if (magic != FormatSpec.MAGIC_NUMBER) {
@@ -241,7 +241,7 @@ final public class BinaryDictionaryGetter { 
            final int formatVersion = buffer.readInt();

            final int headerSize = buffer.readInt();

            final HashMap<String, String> options = CollectionUtils.newHashMap();

            BinaryDictInputOutput.populateOptions(buffer, headerSize, options);

            BinaryDictInputUtils.populateOptions(buffer, headerSize, options);



            final String version = options.get(VERSION_KEY);

            if (null == version) {

java/src/com/android/inputmethod/latin/DictionaryWriter.java

+2 −2
Original line number Diff line number Diff line
@@ -20,7 +20,7 @@ import android.content.Context; 


import com.android.inputmethod.keyboard.ProximityInfo;

import com.android.inputmethod.latin.SuggestedWords.SuggestedWordInfo;

import com.android.inputmethod.latin.makedict.BinaryDictInputOutput;

import com.android.inputmethod.latin.makedict.BinaryDictOutputUtils;

import com.android.inputmethod.latin.makedict.FormatSpec;

import com.android.inputmethod.latin.makedict.FusionDictionary;

import com.android.inputmethod.latin.makedict.FusionDictionary.Node;
@@ -87,7 +87,7 @@ public class DictionaryWriter extends AbstractDictionaryWriter { 
    @Override

    protected void writeBinaryDictionary(final FileOutputStream out)

            throws IOException, UnsupportedFormatException {

        BinaryDictInputOutput.writeDictionaryBinary(out, mFusionDictionary, FORMAT_OPTIONS);

        BinaryDictOutputUtils.writeDictionaryBinary(out, mFusionDictionary, FORMAT_OPTIONS);

    }



    @Override

java/src/com/android/inputmethod/latin/makedict/BinaryDictIOUtils.java

+42 −26
Original line number Diff line number Diff line
@@ -18,8 +18,8 @@ package com.android.inputmethod.latin.makedict; 


import com.android.inputmethod.annotations.UsedForTesting;

import com.android.inputmethod.latin.Constants;

import com.android.inputmethod.latin.makedict.BinaryDictInputOutput.CharEncoding;

import com.android.inputmethod.latin.makedict.BinaryDictInputOutput.FusionDictionaryBufferInterface;

import com.android.inputmethod.latin.makedict.BinaryDictInputUtils.CharEncoding;

import com.android.inputmethod.latin.makedict.BinaryDictInputUtils.FusionDictionaryBufferInterface;

import com.android.inputmethod.latin.makedict.FormatSpec.FileHeader;

import com.android.inputmethod.latin.makedict.FormatSpec.FormatOptions;

import com.android.inputmethod.latin.makedict.FusionDictionary.CharGroup;
@@ -58,6 +58,22 @@ public final class BinaryDictIOUtils { 
        }

    }



    static int getChildrenAddressSize(final int optionFlags,

            final FormatOptions formatOptions) {

        if (formatOptions.mSupportsDynamicUpdate) return FormatSpec.SIGNED_CHILDREN_ADDRESS_SIZE;

        switch (optionFlags & FormatSpec.MASK_GROUP_ADDRESS_TYPE) {

            case FormatSpec.FLAG_GROUP_ADDRESS_TYPE_ONEBYTE:

                return 1;

            case FormatSpec.FLAG_GROUP_ADDRESS_TYPE_TWOBYTES:

                return 2;

            case FormatSpec.FLAG_GROUP_ADDRESS_TYPE_THREEBYTES:

                return 3;

            case FormatSpec.FLAG_GROUP_ADDRESS_TYPE_NOADDRESS:

            default:

                return 0;

        }

    }



    /**

     * Tours all node without recursive call.

     */
@@ -86,7 +102,7 @@ public final class BinaryDictIOUtils { 
            if (index != p.mLength) index = p.mLength;



            if (p.mNumOfCharGroup == Position.NOT_READ_GROUPCOUNT) {

                p.mNumOfCharGroup = BinaryDictInputOutput.readCharGroupCount(buffer);

                p.mNumOfCharGroup = BinaryDictInputUtils.readCharGroupCount(buffer);

                p.mAddress += getGroupCountSize(p.mNumOfCharGroup);

                p.mPosition = 0;

            }
@@ -94,8 +110,8 @@ public final class BinaryDictIOUtils { 
                stack.pop();

                continue;

            }

            CharGroupInfo info = BinaryDictInputOutput.readCharGroup(buffer,

                    p.mAddress - headerSize, formatOptions);

            CharGroupInfo info = BinaryDictInputUtils.readCharGroup(buffer, p.mAddress - headerSize,

                    formatOptions);

            for (int i = 0; i < info.mCharacters.length; ++i) {

                pushedChars[index++] = info.mCharacters[i];

            }
@@ -153,7 +169,7 @@ public final class BinaryDictIOUtils { 
            final Map<Integer, ArrayList<PendingAttribute>> bigrams) throws IOException,

            UnsupportedFormatException {

        // Read header

        final FileHeader header = BinaryDictInputOutput.readHeader(reader.getBuffer());

        final FileHeader header = BinaryDictInputUtils.readHeader(reader.getBuffer());

        readUnigramsAndBigramsBinaryInner(reader.getBuffer(), header.mHeaderSize, words,

                frequencies, bigrams, header.mFormatOptions);

    }
@@ -174,18 +190,18 @@ public final class BinaryDictIOUtils { 
        if (word == null) return FormatSpec.NOT_VALID_WORD;

        if (buffer.position() != 0) buffer.position(0);



        final FileHeader header = BinaryDictInputOutput.readHeader(buffer);

        final FileHeader header = BinaryDictInputUtils.readHeader(buffer);

        int wordPos = 0;

        final int wordLen = word.codePointCount(0, word.length());

        for (int depth = 0; depth < Constants.DICTIONARY_MAX_WORD_LENGTH; ++depth) {

            if (wordPos >= wordLen) return FormatSpec.NOT_VALID_WORD;



            do {

                final int charGroupCount = BinaryDictInputOutput.readCharGroupCount(buffer);

                final int charGroupCount = BinaryDictInputUtils.readCharGroupCount(buffer);

                boolean foundNextCharGroup = false;

                for (int i = 0; i < charGroupCount; ++i) {

                    final int charGroupPos = buffer.position();

                    final CharGroupInfo currentInfo = BinaryDictInputOutput.readCharGroup(buffer,

                    final CharGroupInfo currentInfo = BinaryDictInputUtils.readCharGroup(buffer,

                            buffer.position(), header.mFormatOptions);

                    final boolean isMovedGroup = isMovedGroup(currentInfo.mFlags,

                            header.mFormatOptions);
@@ -271,7 +287,7 @@ public final class BinaryDictIOUtils { 
     */

    private static int writeVariableAddress(final OutputStream destination, final int value)

            throws IOException {

        switch (BinaryDictInputOutput.getByteSize(value)) {

        switch (BinaryDictOutputUtils.getByteSize(value)) {

        case 1:

            destination.write((byte)value);

            break;
@@ -285,15 +301,15 @@ public final class BinaryDictIOUtils { 
            destination.write((byte)(0xFF & value));

            break;

        }

        return BinaryDictInputOutput.getByteSize(value);

        return BinaryDictOutputUtils.getByteSize(value);

    }



    static void skipCharGroup(final FusionDictionaryBufferInterface buffer,

            final FormatOptions formatOptions) {

        final int flags = buffer.readUnsignedByte();

        BinaryDictInputOutput.readParentAddress(buffer, formatOptions);

        BinaryDictInputUtils.readParentAddress(buffer, formatOptions);

        skipString(buffer, (flags & FormatSpec.FLAG_HAS_MULTIPLE_CHARS) != 0);

        BinaryDictInputOutput.readChildrenAddress(buffer, flags, formatOptions);

        BinaryDictInputUtils.readChildrenAddress(buffer, flags, formatOptions);

        if ((flags & FormatSpec.FLAG_IS_TERMINAL) != 0) buffer.readUnsignedByte();

        if ((flags & FormatSpec.FLAG_HAS_SHORTCUT_TARGETS) != 0) {

            final int shortcutsSize = buffer.readUnsignedShort();
@@ -411,14 +427,14 @@ public final class BinaryDictIOUtils { 


        if (info.mShortcutTargets != null && info.mShortcutTargets.size() > 0) {

            final int shortcutListSize =

                    BinaryDictInputOutput.getShortcutListSize(info.mShortcutTargets);

                    BinaryDictOutputUtils.getShortcutListSize(info.mShortcutTargets);

            destination.write((byte)(shortcutListSize >> 8));

            destination.write((byte)(shortcutListSize & 0xFF));

            size += 2;

            final Iterator<WeightedString> shortcutIterator = info.mShortcutTargets.iterator();

            while (shortcutIterator.hasNext()) {

                final WeightedString target = shortcutIterator.next();

                destination.write((byte)BinaryDictInputOutput.makeShortcutFlags(

                destination.write((byte)BinaryDictOutputUtils.makeShortcutFlags(

                        shortcutIterator.hasNext(), target.mFrequency));

                size++;

                size += writeString(destination, target.mWord);
@@ -427,7 +443,7 @@ public final class BinaryDictIOUtils { 


        if (info.mBigrams != null) {

            // TODO: Consolidate this code with the code that computes the size of the bigram list

            //        in BinaryDictionaryInputOutput#computeActualNodeSize

            //        in BinaryDictionaryOutput#computeActualNodeSize

            for (int i = 0; i < info.mBigrams.size(); ++i) {



                final int bigramFrequency = info.mBigrams.get(i).mFrequency;
@@ -437,7 +453,7 @@ public final class BinaryDictIOUtils { 
                final int bigramOffset = info.mBigrams.get(i).mAddress - (info.mOriginalAddress

                        + size);

                bigramFlags |= (bigramOffset < 0) ? FormatSpec.FLAG_ATTRIBUTE_OFFSET_NEGATIVE : 0;

                switch (BinaryDictInputOutput.getByteSize(bigramOffset)) {

                switch (BinaryDictOutputUtils.getByteSize(bigramOffset)) {

                case 1:

                    bigramFlags |= FormatSpec.FLAG_ATTRIBUTE_ADDRESS_TYPE_ONEBYTE;

                    break;
@@ -461,18 +477,18 @@ public final class BinaryDictIOUtils { 
     */

    static int computeGroupSize(final CharGroupInfo info, final FormatOptions formatOptions) {

        int size = FormatSpec.GROUP_FLAGS_SIZE + FormatSpec.PARENT_ADDRESS_SIZE

                + BinaryDictInputOutput.getGroupCharactersSize(info.mCharacters)

                + BinaryDictInputOutput.getChildrenAddressSize(info.mFlags, formatOptions);

                + BinaryDictOutputUtils.getGroupCharactersSize(info.mCharacters)

                + getChildrenAddressSize(info.mFlags, formatOptions);

        if ((info.mFlags & FormatSpec.FLAG_IS_TERMINAL) != 0) {

            size += FormatSpec.GROUP_FREQUENCY_SIZE;

        }

        if (info.mShortcutTargets != null && !info.mShortcutTargets.isEmpty()) {

            size += BinaryDictInputOutput.getShortcutListSize(info.mShortcutTargets);

            size += BinaryDictOutputUtils.getShortcutListSize(info.mShortcutTargets);

        }

        if (info.mBigrams != null) {

            for (final PendingAttribute attr : info.mBigrams) {

                size += FormatSpec.GROUP_FLAGS_SIZE;

                size += BinaryDictInputOutput.getByteSize(attr.mAddress);

                size += BinaryDictOutputUtils.getByteSize(attr.mAddress);

            }

        }

        return size;
@@ -520,9 +536,9 @@ public final class BinaryDictIOUtils { 
        int position = getTerminalPosition(buffer, word);

        if (position != FormatSpec.NOT_VALID_WORD) {

            buffer.position(0);

            final FileHeader header = BinaryDictInputOutput.readHeader(buffer);

            final FileHeader header = BinaryDictInputUtils.readHeader(buffer);

            buffer.position(position);

            return BinaryDictInputOutput.readCharGroup(buffer, position, header.mFormatOptions);

            return BinaryDictInputUtils.readCharGroup(buffer, position, header.mFormatOptions);

        }

        return null;

    }
@@ -544,10 +560,10 @@ public final class BinaryDictIOUtils { 
        final FileInputStream inStream = new FileInputStream(file);

        try {

            inStream.read(buffer);

            final BinaryDictInputOutput.ByteBufferWrapper wrapper =

                    new BinaryDictInputOutput.ByteBufferWrapper(inStream.getChannel().map(

            final BinaryDictInputUtils.ByteBufferWrapper wrapper =

                    new BinaryDictInputUtils.ByteBufferWrapper(inStream.getChannel().map(

                            FileChannel.MapMode.READ_ONLY, offset, length));

            return BinaryDictInputOutput.readHeader(wrapper);

            return BinaryDictInputUtils.readHeader(wrapper);

        } finally {

            inStream.close();

        }

java/src/com/android/inputmethod/latin/makedict/BinaryDictInputUtils.java

0 → 100644
+811 −0

File added.

Preview size limit exceeded, changes collapsed.

java/src/com/android/inputmethod/latin/makedict/BinaryDictInputOutput.java→java/src/com/android/inputmethod/latin/makedict/BinaryDictOutputUtils.java

+23 −805

File changed and moved.

Preview size limit exceeded, changes collapsed.