Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f5b55cb7 authored by Jean Chalard's avatar Jean Chalard
Browse files

Compute variables closer to where they are used (A115) 

This improves locality, it's better for readability/performance

Change-Id: Ibb1efaf86e362dd2c9398722d0da2144df96b333
parent 2549b497

java/src/com/android/inputmethod/latin/Suggest.java

+3 −4
Original line number Diff line number Diff line
@@ -169,9 +169,6 @@ public class Suggest { 
    private SuggestedWords getSuggestedWordsForTypingInput(

            final WordComposer wordComposer, CharSequence prevWordForBigram,

            final ProximityInfo proximityInfo, final boolean isCorrectionEnabled) {

        final boolean isPrediction = !wordComposer.isComposingWord();

        final boolean isFirstCharCapitalized = wordComposer.isFirstCharCapitalized();

        final boolean isAllUpperCase = wordComposer.isAllUpperCase();

        final int trailingSingleQuotesCount = wordComposer.trailingSingleQuotesCount();

        final BoundedTreeSet suggestionsSet = new BoundedTreeSet(sSuggestedWordInfoComparator,

                MAX_SUGGESTIONS);
@@ -245,6 +242,8 @@ public class Suggest { 
        final ArrayList<SuggestedWordInfo> suggestionsContainer =

                new ArrayList<SuggestedWordInfo>(suggestionsSet);

        final int suggestionsCount = suggestionsContainer.size();

        final boolean isFirstCharCapitalized = wordComposer.isFirstCharCapitalized();

        final boolean isAllUpperCase = wordComposer.isAllUpperCase();

        if (isFirstCharCapitalized || isAllUpperCase || 0 != trailingSingleQuotesCount) {

            for (int i = 0; i < suggestionsCount; ++i) {

                final SuggestedWordInfo wordInfo = suggestionsContainer.get(i);
@@ -282,7 +281,7 @@ public class Suggest { 
                hasAutoCorrection, /* willAutoCorrect */

                false /* isPunctuationSuggestions */,

                false /* isObsoleteSuggestions */,

                isPrediction);

                !wordComposer.isComposingWord() /* isPrediction */);

    }



    // Retrieves suggestions for the batch input.