Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f116f910 authored by Adrian Velicu's avatar Adrian Velicu
Browse files

Making spelling of the word "distracters" consistent

Bug: 17537869
Change-Id: Ibfc1c84aff72aeb76c9b127503369d00f3dfaceb
parent 3676c114
Loading
Loading
Loading
Loading
+1 −1
Original line number Diff line number Diff line
@@ -235,7 +235,7 @@ public final class Suggest {
        SuggestedWordInfo.removeDups(null /* typedWord */, suggestionsContainer);

        // For some reason some suggestions with MIN_VALUE are making their way here.
        // TODO: Find a more robust way to detect distractors.
        // TODO: Find a more robust way to detect distracters.
        for (int i = suggestionsContainer.size() - 1; i >= 0; --i) {
            if (suggestionsContainer.get(i).mScore < SUPPRESS_SUGGEST_THRESHOLD) {
                suggestionsContainer.remove(i);
+6 −6
Original line number Diff line number Diff line
@@ -64,9 +64,9 @@ public class DistracterFilterCheckingExactMatchesAndSuggestions implements Distr
    private final Object mLock = new Object();

    // If the score of the top suggestion exceeds this value, the tested word (e.g.,
    // an OOV, a misspelling, or an in-vocabulary word) would be considered as a distractor to
    // an OOV, a misspelling, or an in-vocabulary word) would be considered as a distracter to
    // words in dictionary. The greater the threshold is, the less likely the tested word would
    // become a distractor, which means the tested word will be more likely to be added to
    // become a distracter, which means the tested word will be more likely to be added to
    // the dictionary.
    private static final float DISTRACTER_WORD_SCORE_THRESHOLD = 0.4f;

@@ -196,7 +196,7 @@ public class DistracterFilterCheckingExactMatchesAndSuggestions implements Distr
        }
        final boolean Word = dictionaryFacilitator.isValidWord(testedWord, false /* ignoreCase */);
        if (Word) {
            // Valid word is not a distractor.
            // Valid word is not a distracter.
            if (DEBUG) {
                Log.d(TAG, "isDistracter: false (valid word)");
            }
@@ -257,12 +257,12 @@ public class DistracterFilterCheckingExactMatchesAndSuggestions implements Distr
            return false;
        }
        final SuggestedWordInfo firstSuggestion = suggestionResults.first();
        final boolean isDistractor = suggestionExceedsDistracterThreshold(
        final boolean isDistracter = suggestionExceedsDistracterThreshold(
                firstSuggestion, consideredWord, DISTRACTER_WORD_SCORE_THRESHOLD);
        if (DEBUG) {
            Log.d(TAG, "isDistracter: " + isDistractor);
            Log.d(TAG, "isDistracter: " + isDistracter);
        }
        return isDistractor;
        return isDistracter;
    }

    private static boolean suggestionExceedsDistracterThreshold(final SuggestedWordInfo suggestion,
+1 −1
Original line number Diff line number Diff line
@@ -57,7 +57,7 @@ public class DistracterFilterTest extends AndroidTestCase {
        mDistracterFilter.close();
    }

    public void testIsDistractorToWordsInDictionaries() {
    public void testIsDistracterToWordsInDictionaries() {
        final PrevWordsInfo EMPTY_PREV_WORDS_INFO = PrevWordsInfo.EMPTY_PREV_WORDS_INFO;

        final Locale localeEnUs = new Locale("en", "US");