Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ed3758e3 authored by Tadashi G. Takaoka's avatar Tadashi G. Takaoka Committed by Android (Google) Code Review
Browse files

Merge "Tune the threshold of fullscreen mode from 2.5in to 500dip"

parents ae56d5c3 f80b6a06

java/res/values/dimens.xml

+3 −2
Original line number Diff line number Diff line
@@ -95,8 +95,9 @@ 
    <integer name="center_suggestion_percentile">36</integer>



    <!-- If the screen height in landscape is larger than the below value, then the keyboard

         will not go into extract (fullscreen) mode. -->

    <dimen name="max_height_for_fullscreen">2.5in</dimen>

         will not go into extract (fullscreen) mode.

         Current value is approximate to 7-inch tablet height - system navigation bar height. -->

    <dimen name="max_height_for_fullscreen">500dip</dimen>



    <dimen name="key_hysteresis_distance">0.05in</dimen>

</resources>

java/src/com/android/inputmethod/latin/LatinIME.java

+5 −5
Original line number Diff line number Diff line
@@ -1003,12 +1003,12 @@ public class LatinIME extends InputMethodServiceCompatWrapper implements Keyboar 
            if ((imeOptions & EditorInfo.IME_FLAG_NO_EXTRACT_UI) != 0)

                return false;

        }



        final Resources res = mResources;

        DisplayMetrics dm = res.getDisplayMetrics();

        float displayHeight = dm.heightPixels;

        // If the display is more than X inches high, don't go to fullscreen mode

        float dimen = res.getDimension(R.dimen.max_height_for_fullscreen);

        if (displayHeight > dimen) {

        final DisplayMetrics dm = res.getDisplayMetrics();

        // If the display is more than X DIP high, don't go to fullscreen mode

        final int threshold = res.getDimensionPixelSize(R.dimen.max_height_for_fullscreen);

        if (dm.heightPixels >= threshold) {

            return false;

        } else {

            return super.onEvaluateFullscreenMode();