Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ca17ed7d authored by Keisuke Kuroyanagi's avatar Keisuke Kuroyanagi
Browse files

Fix: BoS prediction is shown after inputting just once. 

Change-Id: Ibba209f47cb5b1a4b08281689d607711b8dcfad4
parent dbeed7e4

native/jni/src/suggest/policyimpl/dictionary/structure/backward/v402/ver4_patricia_trie_policy.cpp

+4 −1
Original line number Diff line number Diff line
@@ -428,7 +428,10 @@ bool Ver4PatriciaTriePolicy::updateCounter(const PrevWordsInfo *const prevWordsI 
        AKLOGE("Cannot update unigarm entry in updateCounter().");

        return false;

    }

    const NgramProperty ngramProperty(wordCodePoints.toVector(), probability, historicalInfo);

    const int probabilityForNgram = prevWordsInfo->isNthPrevWordBeginningOfSentence(1 /* n */)

            ? NOT_A_PROBABILITY : probability;

    const NgramProperty ngramProperty(wordCodePoints.toVector(), probabilityForNgram,

            historicalInfo);

    if (!addNgramEntry(prevWordsInfo, &ngramProperty)) {

        AKLOGE("Cannot update unigarm entry in updateCounter().");

        return false;

tests/src/com/android/inputmethod/latin/BinaryDictionaryDecayingTests.java

+3 −0
Original line number Diff line number Diff line
@@ -611,6 +611,7 @@ public class BinaryDictionaryDecayingTests extends AndroidTestCase { 
                mCurrentTime);

        final NgramContext beginningOfSentenceContext = NgramContext.BEGINNING_OF_SENTENCE;

        onInputWordWithBeginningOfSentenceContext(binaryDictionary, "aaa", true /* isValidWord */);

        onInputWordWithBeginningOfSentenceContext(binaryDictionary, "aaa", true /* isValidWord */);

        assertTrue(binaryDictionary.isValidNgram(beginningOfSentenceContext, "aaa"));

        onInputWordWithBeginningOfSentenceContext(binaryDictionary, "aaa", true /* isValidWord */);

        onInputWordWithBeginningOfSentenceContext(binaryDictionary, "bbb", true /* isValidWord */);
@@ -622,6 +623,8 @@ public class BinaryDictionaryDecayingTests extends AndroidTestCase { 
        assertFalse(binaryDictionary.isValidNgram(beginningOfSentenceContext, "bbb"));



        onInputWordWithBeginningOfSentenceContext(binaryDictionary, "aaa", true /* isValidWord */);

        onInputWordWithBeginningOfSentenceContext(binaryDictionary, "aaa", true /* isValidWord */);

        onInputWordWithBeginningOfSentenceContext(binaryDictionary, "bbb", true /* isValidWord */);

        onInputWordWithBeginningOfSentenceContext(binaryDictionary, "bbb", true /* isValidWord */);

        assertTrue(binaryDictionary.isValidNgram(beginningOfSentenceContext, "aaa"));

        assertTrue(binaryDictionary.isValidNgram(beginningOfSentenceContext, "bbb"));