Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c2fbd7c6 authored by Ben Cheng's avatar Ben Cheng
Browse files

Force inlining Correction::isSingleQuote 

Also, only apply -Winline with GCC 4.6. There are some copy constructors
that GCC 4.7/4.8 fail to inline.

Change-Id: I97906045224e89377e8ea6add07a79fa088648af
parent 4cdb7ccb

native/jni/Android.mk

+1 −1
Original line number Diff line number Diff line
@@ -32,7 +32,7 @@ LOCAL_CFLAGS += -Werror -Wall -Wextra -Weffc++ -Wformat=2 -Wcast-qual -Wcast-ali 
    -Wwrite-strings -Wfloat-equal -Wpointer-arith -Winit-self -Wredundant-decls -Wno-system-headers



ifeq ($(TARGET_ARCH), arm)

ifneq ($(TARGET_GCC_VERSION), 4.7)

ifeq ($(TARGET_GCC_VERSION), 4.6)

LOCAL_CFLAGS += -Winline

endif # TARGET_GCC_VERSION

endif # TARGET_ARCH

native/jni/src/correction.h

+1 −1
Original line number Diff line number Diff line
@@ -307,7 +307,7 @@ inline void Correction::startToTraverseAllNodes() { 
    mNeedsToTraverseAllNodes = true;

}



inline bool Correction::isSingleQuote(const int c) {

AK_FORCE_INLINE bool Correction::isSingleQuote(const int c) {

    const int userTypedChar = mProximityInfoState.getPrimaryCodePointAt(mInputIndex);

    return (c == KEYCODE_SINGLE_QUOTE && userTypedChar != KEYCODE_SINGLE_QUOTE);

}