Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b1bc5fd8 authored by Gilles Debunne's avatar Gilles Debunne Committed by Chet Haase
Browse files

Bug 5352720: IME_FLAG_NO_EXTRACT_UI is not enforced

CL https://android-git.corp.google.com/g/#/c/136474 refactored
the fullscreen test, but ithe IME_FLAG_NO_EXTRACT_UI test was
lost in the process.

Note that there is still a problem (orthogonal to that change
with key_preview_backing, which appears opaque and black sometimes.

I'll re-open 5315001.

Change-Id: If3a73179d21eaca10bdc948db7bac4b4f7a88d34
parent d79ca325
Loading
Loading
Loading
Loading
+11 −2
Original line number Diff line number Diff line
@@ -991,8 +991,17 @@ public class LatinIME extends InputMethodServiceCompatWrapper implements Keyboar

    @Override
    public boolean onEvaluateFullscreenMode() {
        return super.onEvaluateFullscreenMode()
                && mResources.getBoolean(R.bool.config_use_fullscreen_mode);
        if (!super.onEvaluateFullscreenMode()) return false;

        final EditorInfo ei = getCurrentInputEditorInfo();
        if (ei != null) {
            final int imeOptions = ei.imeOptions;
            if ((imeOptions & EditorInfo.IME_FLAG_NO_EXTRACT_UI) != 0) {
                return false;
            }
        }

        return mResources.getBoolean(R.bool.config_use_fullscreen_mode);
    }

    @Override