Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit af580087 authored by Amith Yamasani's avatar Amith Yamasani
Browse files

DO NOT MERGE ( Already in master ): Fix a global reference leak. # 2026571 

Fix incorrect usage of Release<>ArrayElements. Code was not releasing global
references. IME would have crashed in 50000 key presses.
parent cc7c8ea4

dictionary/jni/com_android_inputmethod_latin_BinaryDictionary.cpp

+2 −2
Original line number Diff line number Diff line
@@ -100,9 +100,9 @@ static int latinime_BinaryDictionary_getSuggestions( 
    int count = dictionary->getSuggestions(inputCodes, arraySize, (unsigned short*) outputChars, frequencies,

            maxWordLength, maxWords, maxAlternatives);

    

    env->ReleaseIntArrayElements(frequencyArray, frequencies, JNI_COMMIT);

    env->ReleaseIntArrayElements(frequencyArray, frequencies, 0);

    env->ReleaseIntArrayElements(inputArray, inputCodes, JNI_ABORT);

    env->ReleaseCharArrayElements(outputArray, outputChars, JNI_COMMIT);

    env->ReleaseCharArrayElements(outputArray, outputChars, 0);

    

    return count;

}