Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ac6dfaf8 authored by Jean Chalard's avatar Jean Chalard
Browse files

[IL58] Simplification 

No need to test multiple times for this. Let's just never do useless
stuff, and only test for that once.

Bug: 8636060
Change-Id: I50a9e4da769fbec44fbb12eedfed03aad924cc2c
parent 47f04e2e

java/src/com/android/inputmethod/latin/LatinIME.java

+5 −5
Original line number Diff line number Diff line
@@ -234,6 +234,9 @@ public class LatinIME extends InputMethodService implements KeyboardActionListen 
        }



        public void postResumeSuggestions() {

            if (!getOwnerInstance().mSettings.getCurrent().isSuggestionStripVisible()) {

                return;

            }

            removeMessages(MSG_RESUME_SUGGESTIONS);

            sendMessageDelayed(obtainMessage(MSG_RESUME_SUGGESTIONS), mDelayUpdateSuggestions);

        }
@@ -959,11 +962,8 @@ public class LatinIME extends InputMethodService implements KeyboardActionListen 
                        newSelStart, newSelEnd, false /* shouldFinishComposition */);

            }



            // We moved the cursor. If we are touching a word, we need to resume suggestion,

            // unless suggestions are off.

            if (isSuggestionsStripVisible()) {

            // We moved the cursor. If we are touching a word, we need to resume suggestion.

            mHandler.postResumeSuggestions();

            }

            // Reset the last recapitalization.

            mInputLogic.mRecapitalizeStatus.deactivate();

            mKeyboardSwitcher.updateShiftState();

java/src/com/android/inputmethod/latin/inputlogic/InputLogic.java

+0 −2
Original line number Diff line number Diff line
@@ -1061,8 +1061,6 @@ public final class InputLogic { 
        // recorrection. This is a temporary, stopgap measure that will be removed later.

        // TODO: remove this.

        if (settingsValues.isBrokenByRecorrection()) return;

        // A simple way to test for support from the TextView.

        if (!mLatinIME.isSuggestionsStripVisible()) return;

        // Recorrection is not supported in languages without spaces because we don't know

        // how to segment them yet.

        if (!settingsValues.mSpacingAndPunctuations.mCurrentLanguageHasSpaces) return;