Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8da0c932 authored by Tom Ouyang's avatar Tom Ouyang
Browse files

Reduce MAX_NORM_DISTANCE_FOR_EDIT in typing model after recent logic improvements 

After recent logic improvements we can now safely reduce MAX_NORM_DISTANCE_FOR_EDIT.
This leads to better regression test performance and faster runtime speed.

Bug: 8633962
Change-Id: Ie0db73680b32687ff4d8ea5dfae47dee5c7c66a3
parent 254949d8

native/jni/src/suggest/policyimpl/typing/scoring_params.cpp

+1 −1
Original line number Diff line number Diff line
@@ -48,5 +48,5 @@ const float ScoringParams::HAS_EDIT_CORRECTION_TERMINAL_COST = 0.038f; 
const float ScoringParams::HAS_MULTI_WORD_TERMINAL_COST = 0.444f;

const float ScoringParams::TYPING_BASE_OUTPUT_SCORE = 1.0f;

const float ScoringParams::TYPING_MAX_OUTPUT_SCORE_PER_INPUT = 0.1f;

const float ScoringParams::MAX_NORM_DISTANCE_FOR_EDIT = 0.1f;

const float ScoringParams::NORMALIZED_SPATIAL_DISTANCE_THRESHOLD_FOR_EDIT = 0.06f;

} // namespace latinime

native/jni/src/suggest/policyimpl/typing/scoring_params.h

+1 −1
Original line number Diff line number Diff line
@@ -57,7 +57,7 @@ class ScoringParams { 
    static const float HAS_MULTI_WORD_TERMINAL_COST;

    static const float TYPING_BASE_OUTPUT_SCORE;

    static const float TYPING_MAX_OUTPUT_SCORE_PER_INPUT;

    static const float MAX_NORM_DISTANCE_FOR_EDIT;

    static const float NORMALIZED_SPATIAL_DISTANCE_THRESHOLD_FOR_EDIT;



 private:

    DISALLOW_IMPLICIT_CONSTRUCTORS(ScoringParams);

native/jni/src/suggest/policyimpl/typing/typing_traversal.h

+1 −1
Original line number Diff line number Diff line
@@ -39,7 +39,7 @@ class TypingTraversal : public Traversal { 


    AK_FORCE_INLINE bool allowsErrorCorrections(const DicNode *const dicNode) const {

        return dicNode->getNormalizedSpatialDistance()

                < ScoringParams::MAX_NORM_DISTANCE_FOR_EDIT;

                < ScoringParams::NORMALIZED_SPATIAL_DISTANCE_THRESHOLD_FOR_EDIT;

    }



    AK_FORCE_INLINE bool isOmission(const DicTraverseSession *const traverseSession,