Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 88110d17 authored by Tadashi G. Takaoka's avatar Tadashi G. Takaoka
Browse files

Clear CandidateView in onStartInputView 

Before starting input on new TextView, we must clear the CandidateView
because it may hold the suggestion of previous TextView or even worse
the suggestions pane has been expanded and keyboard has been hidden.

Bug: 4995414
Change-Id: If848320c1a510e7018d36ed8ac61291be2fc6ce5
parent 273e5d60

java/src/com/android/inputmethod/latin/CandidateView.java

+1 −1
Original line number Original line Diff line number Diff line
@@ -701,9 +701,9 @@ public class CandidateView extends LinearLayout implements OnClickListener, OnLo 
        mShowingAddToDictionary = false;

        mShowingAddToDictionary = false;

        mShowingAutoCorrectionInverted = false;

        mShowingAutoCorrectionInverted = false;

        mTouchToSave.setVisibility(GONE);

        mTouchToSave.setVisibility(GONE);

        mCandidatesStrip.setVisibility(VISIBLE);

        mCandidatesStrip.removeAllViews();

        mCandidatesStrip.removeAllViews();

        mCandidatesPane.removeAllViews();

        mCandidatesPane.removeAllViews();

        closeCandidatesPane();

    }

    }





    private void hidePreview() {

    private void hidePreview() {

java/src/com/android/inputmethod/latin/LatinIME.java

+2 −0
Original line number Original line Diff line number Diff line
@@ -580,6 +580,8 @@ public class LatinIME extends InputMethodServiceCompatWrapper implements Keyboar 
            switcher.updateShiftState();

            switcher.updateShiftState();

        }

        }





        if (mCandidateView != null)

            mCandidateView.clear();

        setSuggestionStripShownInternal(isCandidateStripVisible(), /* needsInputViewShown */ false);

        setSuggestionStripShownInternal(isCandidateStripVisible(), /* needsInputViewShown */ false);

        // Delay updating suggestions because keyboard input view may not be shown at this point.

        // Delay updating suggestions because keyboard input view may not be shown at this point.

        mHandler.postUpdateSuggestions();

        mHandler.postUpdateSuggestions();