Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7aa47cb3 authored by Jean Chalard's avatar Jean Chalard
Browse files

Only do double-space-period on real text fields. 

Bug: 15559216
Change-Id: Id6ecadc58c03889496967d67371457e4050d695b
parent 64dd48e3

java/src/com/android/inputmethod/latin/InputAttributes.java

+11 −0
Original line number Diff line number Diff line
@@ -42,6 +42,7 @@ public final class InputAttributes { 
    final public boolean mApplicationSpecifiedCompletionOn;

    final public boolean mShouldInsertSpacesAutomatically;

    final public boolean mShouldShowVoiceInputKey;

    final public boolean mIsGeneralTextInput;

    final private int mInputType;

    final private EditorInfo mEditorInfo;

    final private String mPackageNameForPrivateImeOptions;
@@ -76,6 +77,7 @@ public final class InputAttributes { 
            mApplicationSpecifiedCompletionOn = false;

            mShouldInsertSpacesAutomatically = false;

            mShouldShowVoiceInputKey = false;

            mIsGeneralTextInput = false;

            return;

        }

        // inputClass == InputType.TYPE_CLASS_TEXT
@@ -117,6 +119,15 @@ public final class InputAttributes { 
                || (!flagAutoCorrect && !flagMultiLine);



        mApplicationSpecifiedCompletionOn = flagAutoComplete && isFullscreenMode;



        // If we come here, inputClass is always TYPE_CLASS_TEXT

        mIsGeneralTextInput = InputType.TYPE_TEXT_VARIATION_EMAIL_ADDRESS != variation

                && InputType.TYPE_TEXT_VARIATION_PASSWORD != variation

                && InputType.TYPE_TEXT_VARIATION_PHONETIC != variation

                && InputType.TYPE_TEXT_VARIATION_URI != variation

                && InputType.TYPE_TEXT_VARIATION_VISIBLE_PASSWORD != variation

                && InputType.TYPE_TEXT_VARIATION_WEB_EMAIL_ADDRESS != variation

                && InputType.TYPE_TEXT_VARIATION_WEB_PASSWORD != variation;

    }



    public boolean isTypeNull() {

java/src/com/android/inputmethod/latin/settings/SettingsValues.java

+2 −1
Original line number Diff line number Diff line
@@ -148,7 +148,8 @@ public final class SettingsValues { 
                ? Settings.readShowsLanguageSwitchKey(prefs) : true /* forcibly */;

        mUseContactsDict = prefs.getBoolean(Settings.PREF_KEY_USE_CONTACTS_DICT, true);

        mUsePersonalizedDicts = prefs.getBoolean(Settings.PREF_KEY_USE_PERSONALIZED_DICTS, true);

        mUseDoubleSpacePeriod = prefs.getBoolean(Settings.PREF_KEY_USE_DOUBLE_SPACE_PERIOD, true);

        mUseDoubleSpacePeriod = prefs.getBoolean(Settings.PREF_KEY_USE_DOUBLE_SPACE_PERIOD, true)

                && inputAttributes.mIsGeneralTextInput;

        mBlockPotentiallyOffensive = Settings.readBlockPotentiallyOffensive(prefs, res);

        mAutoCorrectEnabled = Settings.readAutoCorrectEnabled(autoCorrectionThresholdRawValue, res);

        mBigramPredictionEnabled = readBigramPredictionEnabled(prefs, res);