Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4e746588 authored by Jean Chalard's avatar Jean Chalard
Browse files

Optimization 

All calls to this methods are made with an actual String. No sense
beating ourselves with an interface stick.

Change-Id: I6ef98286be6f81f73864b04f3a17e68f36a6e542
parent 12340726

java/src/com/android/inputmethod/latin/SuggestedWords.java

+3 −3
Original line number Diff line number Diff line
@@ -121,21 +121,21 @@ public class SuggestedWords { 


    public static class SuggestedWordInfo {

        public final CharSequence mWord;

        private final CharSequence mDebugString;

        private final String mDebugString;



        public SuggestedWordInfo(final CharSequence word) {

            mWord = word;

            mDebugString = "";

        }



        public SuggestedWordInfo(final CharSequence word, final CharSequence debugString) {

        public SuggestedWordInfo(final CharSequence word, final String debugString) {

            mWord = word;

            if (null == debugString) throw new NullPointerException("");

            mDebugString = debugString;

        }



        public String getDebugString() {

            return mDebugString.toString();

            return mDebugString;

        }



        @Override

java/src/com/android/inputmethod/latin/suggestions/SuggestionsView.java

+2 −2
Original line number Diff line number Diff line
@@ -502,11 +502,11 @@ public class SuggestionsView extends RelativeLayout implements OnClickListener, 
                    hintView, 1.0f - mCenterSuggestionWeight, ViewGroup.LayoutParams.MATCH_PARENT);

        }



        private static CharSequence getDebugInfo(SuggestedWords suggestions, int pos) {

        private static String getDebugInfo(SuggestedWords suggestions, int pos) {

            if (DBG && pos < suggestions.size()) {

                final SuggestedWordInfo wordInfo = suggestions.getInfo(pos);

                if (wordInfo != null) {

                    final CharSequence debugInfo = wordInfo.getDebugString();

                    final String debugInfo = wordInfo.getDebugString();

                    if (!TextUtils.isEmpty(debugInfo)) {

                        return debugInfo;

                    }