Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 491d451e authored by Jean Chalard's avatar Jean Chalard
Browse files

Fix a bug with the 'add to dict' hint popping up too much 

Not having a main dictionary is not sufficient reason to display
the hint. If the user already added the word to the dictionary then
we shouldn't be displaying it again, even if we don't have a main
dictionary for the current language.

Bug: 6829798
Change-Id: I6b081f51c82ef395fe2e394fd3167363e743ea6f
parent 4702671e

java/src/com/android/inputmethod/latin/LatinIME.java

+3 −9
Original line number Diff line number Diff line
@@ -1883,18 +1883,12 @@ public class LatinIME extends InputMethodService implements KeyboardActionListen 
        mKeyboardSwitcher.updateShiftState();



        // We should show the "Touch again to save" hint if the user pressed the first entry

        // AND either:

        // - There is no dictionary (we know that because we tried to load it => null != mSuggest

        //   AND mSuggest.hasMainDictionary() is false)

        // - There is a dictionary and the word is not in it

        // AND it's in none of our current dictionaries (main, user or otherwise).

        // Please note that if mSuggest is null, it means that everything is off: suggestion

        // and correction, so we shouldn't try to show the hint

        final boolean showingAddToDictionaryHint = index == 0 && mSuggest != null

                // If there is no dictionary the hint should be shown.

                && (!mSuggest.hasMainDictionary()

                        // If "suggestion" is not in the dictionary, the hint should be shown.

                        || !AutoCorrection.isValidWord(

                                mSuggest.getUnigramDictionaries(), suggestion, true));

                // If the suggestion is not in the dictionary, the hint should be shown.

                && !AutoCorrection.isValidWord(mSuggest.getUnigramDictionaries(), suggestion, true);



        Utils.Stats.onSeparator((char)Keyboard.CODE_SPACE, WordComposer.NOT_A_COORDINATE,

                WordComposer.NOT_A_COORDINATE);