Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 296adf57 authored Feb 21, 2014 by Jean Chalard Committed by Android (Google) Code Review Feb 21, 2014

Merge "Change a heuristic and add a log."

parents 1269ae31 3b4c1d30

java/src/com/android/inputmethod/latin/LatinIME.java

+2 −0

Original line number	Diff line number	Diff line
		@@ -750,6 +750,8 @@ public class LatinIME extends InputMethodService implements KeyboardActionListen
		+ ", word caps = "
		+ ((editorInfo.inputType & InputType.TYPE_TEXT_FLAG_CAP_WORDS) != 0));
		}
		Log.i(TAG, "Starting input. Cursor position = "
		+ editorInfo.initialSelStart + "," + editorInfo.initialSelEnd);
		if (ProductionFlag.USES_DEVELOPMENT_ONLY_DIAGNOSTICS) {
		final SharedPreferences prefs = PreferenceManager.getDefaultSharedPreferences(this);
		ResearchLogger.latinIME_onStartInputViewInternal(editorInfo, prefs);

java/src/com/android/inputmethod/latin/RichInputConnection.java

+3 −3

Original line number	Diff line number	Diff line
		@@ -847,9 +847,9 @@ public final class RichInputConnection {
		mExpectedSelStart = mExpectedSelEnd = Constants.NOT_A_CURSOR_POSITION;
		} else {
		final int textLength = textBeforeCursor.length();
		if (textLength > mExpectedSelStart
		\|\| (textLength < Constants.EDITOR_CONTENTS_CACHE_SIZE
		&& mExpectedSelStart < Constants.EDITOR_CONTENTS_CACHE_SIZE)) {
		if (textLength < Constants.EDITOR_CONTENTS_CACHE_SIZE
		&& (textLength > mExpectedSelStart
		\|\| mExpectedSelStart < Constants.EDITOR_CONTENTS_CACHE_SIZE)) {
		// It should not be possible to have only one of those variables be
		// NOT_A_CURSOR_POSITION, so if they are equal, either the selection is zero-sized
		// (simple cursor, no selection) or there is no cursor/we don't know its pos