Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 216fb6a0 authored by Tadashi G. Takaoka's avatar Tadashi G. Takaoka
Browse files

Remove unnecessary harmful finish() from SettingsActivity 

Bug: 8560722
Change-Id: I825b135bd13aca17e712330660978b834648dbc3
parent 1ec4c07a

java/src/com/android/inputmethod/latin/SettingsFragment.java

+2 −7
Original line number Diff line number Diff line
@@ -16,7 +16,6 @@ 


package com.android.inputmethod.latin;



import android.app.Activity;

import android.app.backup.BackupManager;

import android.content.Context;

import android.content.Intent;
@@ -115,12 +114,8 @@ public final class SettingsFragment extends InputMethodSettingsFragment 
            if (FeedbackUtils.isFeedbackFormSupported()) {

                feedbackSettings.setOnPreferenceClickListener(new OnPreferenceClickListener() {

                    @Override

                    public boolean onPreferenceClick(Preference arg0) {

                        final Activity activity = getActivity();

                        FeedbackUtils.showFeedbackForm(activity);

                        if (!activity.isFinishing()) {

                            activity.finish();

                        }

                    public boolean onPreferenceClick(final Preference pref) {

                        FeedbackUtils.showFeedbackForm(getActivity());

                        return true;

                    }

                });