Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 032cfeef authored by Yusuke Nojima's avatar Yusuke Nojima
Browse files

Delete unused function and add TODO comment for a potential bug. 

Change-Id: I7b16de1bd6b278c51d56eb1904e186c3db3b7f3d
parent 14c840fb

native/src/correction.cpp

+3 −0
Original line number Diff line number Diff line
@@ -429,6 +429,9 @@ inline static void multiplyIntCapped(const int multiplier, int *base) { 
        if (multiplier == 2) {

            *base = TWO_31ST_DIV_2 >= temp ? temp << 1 : S_INT_MAX;

        } else {

            // TODO: This overflow check gives a wrong answer when, for example,

            //       temp = 2^16 + 1 and multiplier = 2^17 + 1.

            //       Fix this behavior.

            const int tempRetval = temp * multiplier;

            *base = tempRetval >= temp ? tempRetval : S_INT_MAX;

        }

native/src/unigram_dictionary.cpp

+0 −14
Original line number Diff line number Diff line
@@ -348,20 +348,6 @@ void UnigramDictionary::getSuggestionCandidates() { 
    }

}



static const int TWO_31ST_DIV_2 = S_INT_MAX / 2;

inline static void multiplyIntCapped(const int multiplier, int *base) {

    const int temp = *base;

    if (temp != S_INT_MAX) {

        // Branch if multiplier == 2 for the optimization

        if (multiplier == 2) {

            *base = TWO_31ST_DIV_2 >= temp ? temp << 1 : S_INT_MAX;

        } else {

            const int tempRetval = temp * multiplier;

            *base = tempRetval >= temp ? tempRetval : S_INT_MAX;

        }

    }

}



void UnigramDictionary::getMissingSpaceWords(

        const int inputLength, const int missingSpacePos, Correction *correction) {

    correction->setCorrectionParams(-1 /* skipPos */, -1 /* excessivePos */,