Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 029d9eeb authored by Keisuke Kuroyanagi's avatar Keisuke Kuroyanagi
Browse files

Fix: Suggested words from user history are invalid. DO NOT MERGE. 

- Suggestions form user history can contain invalid words.
- isValidWord always returns false.

Bug: 11139426
Change-Id: I6075b275603332ddb00f4a9284afcaa82d824270
parent 2e7f360a

java/src/com/android/inputmethod/latin/personalization/DecayingExpandableBinaryDictionaryBase.java

+0 −9
Original line number Diff line number Diff line
@@ -113,15 +113,6 @@ public abstract class DecayingExpandableBinaryDictionaryBase extends ExpandableB 
        return false;

    }



    /**

     * Return whether the passed charsequence is in the dictionary.

     */

    @Override

    public boolean isValidWord(final String word) {

     // Words included only in the user history should be treated as not in dictionary words.

        return false;

    }



    /**

     * Pair will be added to the decaying dictionary.

     *

native/jni/src/suggest/policyimpl/dictionary/dynamic_patricia_trie_policy.cpp

+9 −2
Original line number Diff line number Diff line
@@ -55,9 +55,16 @@ void DynamicPatriciaTriePolicy::createAndGetAllChildNodes(const DicNode *const d 
    readingHelper.initWithPtNodeArrayPos(dicNode->getChildrenPos());

    const DynamicPatriciaTrieNodeReader *const nodeReader = readingHelper.getNodeReader();

    while (!readingHelper.isEnd()) {

        bool isTerminal = nodeReader->isTerminal() && !nodeReader->isDeleted();

        if (isTerminal && mHeaderPolicy.isDecayingDict()) {

            // A DecayingDict may have a terminal PtNode that has a terminal DicNode whose

            // probability is NOT_A_PROBABILITY. In such case, we don't want to treat it as a

            // valid terminal DicNode.

            isTerminal = getProbability(nodeReader->getProbability(), NOT_A_PROBABILITY)

                    != NOT_A_PROBABILITY;

        }

        childDicNodes->pushLeavingChild(dicNode, nodeReader->getHeadPos(),

                nodeReader->getChildrenPos(), nodeReader->getProbability(),

                nodeReader->isTerminal() && !nodeReader->isDeleted(),

                nodeReader->getChildrenPos(), nodeReader->getProbability(), isTerminal,

                nodeReader->hasChildren(), nodeReader->isBlacklisted() || nodeReader->isNotAWord(),

                nodeReader->getCodePointCount(), readingHelper.getMergedNodeCodePoints());

        readingHelper.readNextSiblingNode();