Add tests for Contact* classes (01b02373) · Commits · e / os / android_packages_inputmethods_LatinIME

java/src/com/android/inputmethod/latin/ContactsContentObserver.java

+1 −2

Original line number	Diff line number	Diff line
		@@ -32,7 +32,6 @@ import java.util.concurrent.atomic.AtomicBoolean;
		/**
		* A content observer that listens to updates to content provider {@link Contacts#CONTENT_URI}.
		*/
		// TODO:add test
		public class ContactsContentObserver implements Runnable {
		private static final String TAG = ContactsContentObserver.class.getSimpleName();
		private static final boolean DEBUG = false;
		@@ -82,7 +81,7 @@ public class ContactsContentObserver implements Runnable {
		sRunning.set(false);
		}

		private boolean haveContentsChanged() {
		boolean haveContentsChanged() {
		final long startTime = SystemClock.uptimeMillis();
		final int contactCount = mManager.getContactCount();
		if (contactCount > ContactsDictionaryConstants.MAX_CONTACT_COUNT) {

java/src/com/android/inputmethod/latin/ContactsManager.java

+0 −1

Original line number	Diff line number	Diff line
		@@ -34,7 +34,6 @@ import java.util.concurrent.atomic.AtomicInteger;
		* The manager provides an API for listening to meaning full updates by keeping a
		* measure of the current state of the content provider.
		*/
		// TODO:Add test
		public class ContactsManager {
		private static final String TAG = ContactsManager.class.getSimpleName();
		private static final boolean DEBUG = false;

java/src/com/android/inputmethod/latin/DictionaryFacilitator.java

+13 −0

Original line number	Diff line number	Diff line
		@@ -181,4 +181,17 @@ public interface DictionaryFacilitator {
		int timeStampInSeconds);

		void clearLanguageModel(String filePath);

		/**
		* Lets callers iterate over a given dynamic language model. Each iterate call
		* results in ngrams, their counts, their last updated timestamps and an iteration token
		* that can be used for the next {@link #iterateOverLanguageModel} call.
		*
		* Use empty string for starting the iterator from the begining.
		* Returns empty string if there are no more entries to iterate upon.
		* TODO: Encapsulate the result arrays into a java class.
		*/
		String iterateOverLanguageModel(String filePath, String iterationToken,
		ArrayList<String> outputNgramEntries, ArrayList<Integer> outputNgramCounts,
		ArrayList<Integer> outputNgramTimestamps);
		}

java/src/com/android/inputmethod/latin/DictionaryFacilitatorImpl.java

+8 −0

Original line number	Diff line number	Diff line
		@@ -815,4 +815,12 @@ public class DictionaryFacilitatorImpl implements DictionaryFacilitator {
		public void clearLanguageModel(String filePath) {
		// Do nothing.
		}

		@Override
		public String iterateOverLanguageModel(String filePath, String iterationToken,
		ArrayList<String> outputNgramEntries, ArrayList<Integer> outputNgramCounts,
		ArrayList<Integer> outputNgramTimestamps) {
		// Do nothing.
		return "";
		}
		}

tests/src/com/android/inputmethod/latin/ContactsContentObserverTest.java

0 → 100644

+94 −0

Original line number	Diff line number	Diff line
		/*
		* Copyright (C) 2014 The Android Open Source Project
		*
		* Licensed under the Apache License, Version 2.0 (the "License");
		* you may not use this file except in compliance with the License.
		* You may obtain a copy of the License at
		*
		* http://www.apache.org/licenses/LICENSE-2.0
		*
		* Unless required by applicable law or agreed to in writing, software
		* distributed under the License is distributed on an "AS IS" BASIS,
		* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
		* See the License for the specific language governing permissions and
		* limitations under the License.
		*/

		package com.android.inputmethod.latin;

		import static org.junit.Assert.assertFalse;
		import static org.junit.Assert.assertTrue;
		import static org.mockito.Matchers.eq;
		import static org.mockito.Mockito.validateMockitoUsage;
		import static org.mockito.Mockito.when;

		import android.content.Context;
		import android.provider.ContactsContract.Contacts;
		import android.test.suitebuilder.annotation.SmallTest;

		import org.junit.After;
		import org.junit.Before;
		import org.junit.Test;
		import org.mockito.Mock;
		import org.mockito.MockitoAnnotations;

		import java.util.ArrayList;

		/**
		* Tests for {@link ContactsContentObserver}.
		*/
		@SmallTest
		public class ContactsContentObserverTest {
		private static final int UPDATED_CONTACT_COUNT = 10;
		private static final int STALE_CONTACT_COUNT = 8;
		private static final ArrayList<String> STALE_NAMES_LIST = new ArrayList<>();
		private static final ArrayList<String> UPDATED_NAMES_LIST = new ArrayList<>();

		static {
		STALE_NAMES_LIST.add("Larry Page");
		STALE_NAMES_LIST.add("Roger Federer");
		UPDATED_NAMES_LIST.add("Larry Page");
		UPDATED_NAMES_LIST.add("Roger Federer");
		UPDATED_NAMES_LIST.add("Barak Obama");
		}

		@Mock private ContactsManager mMockManager;
		@Mock private Context mContext;

		private ContactsContentObserver mObserver;

		@Before
		public void setUp() throws Exception {
		MockitoAnnotations.initMocks(this);
		mObserver = new ContactsContentObserver(mMockManager, mContext);
		}

		@After
		public void tearDown() {
		validateMockitoUsage();
		}

		@Test
		public void testHaveContentsChanged_NoChange() {
		when(mMockManager.getContactCount()).thenReturn(STALE_CONTACT_COUNT);
		when(mMockManager.getContactCountAtLastRebuild()).thenReturn(STALE_CONTACT_COUNT);
		when(mMockManager.getValidNames(eq(Contacts.CONTENT_URI))).thenReturn(STALE_NAMES_LIST);
		when(mMockManager.getHashCodeAtLastRebuild()).thenReturn(STALE_NAMES_LIST.hashCode());
		assertFalse(mObserver.haveContentsChanged());
		}
		@Test
		public void testHaveContentsChanged_UpdatedCount() {
		when(mMockManager.getContactCount()).thenReturn(UPDATED_CONTACT_COUNT);
		when(mMockManager.getContactCountAtLastRebuild()).thenReturn(STALE_CONTACT_COUNT);
		assertTrue(mObserver.haveContentsChanged());
		}

		@Test
		public void testHaveContentsChanged_HashUpdate() {
		when(mMockManager.getContactCount()).thenReturn(STALE_CONTACT_COUNT);
		when(mMockManager.getContactCountAtLastRebuild()).thenReturn(STALE_CONTACT_COUNT);
		when(mMockManager.getValidNames(eq(Contacts.CONTENT_URI))).thenReturn(UPDATED_NAMES_LIST);
		when(mMockManager.getHashCodeAtLastRebuild()).thenReturn(STALE_NAMES_LIST.hashCode());
		assertTrue(mObserver.haveContentsChanged());
		}
		}