Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ef9a94b7 authored by Philip P. Moltmann's avatar Philip P. Moltmann
Browse files

Don't dismiss Package installer on unknown sources 

3rd parties might return RESULT_OK from the
ACTION_MANAGE_EXTERNAL_SOURCES activity. In this cases we have to go on
and install the package. Hence we should not finish() the activity when
the unknown sources dialog is dismissed. We should wait until the
activity returns.

Test: Canceled dialog via button and via "back"-key. Entered unknown
      sources setting and checked via debugger that we handle the return
      value.

Change-Id: I41b3b3f0b691e0a110d18d29b965b935bb7a6f74
parent 781335ed

src/com/android/packageinstaller/PackageInstallerActivity.java

+2 −7
Original line number Diff line number Diff line
@@ -326,13 +326,8 @@ public class PackageInstallerActivity extends Activity implements OnCancelListen 
                                    }

                                }

                            })

                    .setOnDismissListener(new DialogInterface.OnDismissListener() {

                        @Override

                        public void onDismiss(DialogInterface dialog) {

                            finish();

                        }

                    })

                    .setNegativeButton(R.string.cancel, null)

                    .setOnCancelListener(dialog -> finish())

                    .setNegativeButton(R.string.cancel, (dialog, which) -> finish())

                    .create();

        }

        return null;