Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d6b33b14 authored by Hai Zhang's avatar Hai Zhang
Browse files

Add a bit of animation to request role dialog item. 

Otherwise the text view jumps around.

Bug: 128713569
Test: manual
Change-Id: I6fc684ae2014b5b5a5b603933ddf67ad1f89f53a
parent 04c916c9

res/layout/request_role_item.xml

+3 −0
Original line number Diff line number Diff line
@@ -23,6 +23,7 @@ 
    android:minHeight="?android:listPreferredItemHeight"

    android:paddingStart="?android:listPreferredItemPaddingStart"

    android:paddingEnd="?android:listPreferredItemPaddingEnd"

    android:clipChildren="false"

    android:gravity="center_vertical"

    android:orientation="horizontal">
@@ -32,10 +33,12 @@ 
        android:layout_height="32dp" />



    <LinearLayout

        android:id="@+id/title_and_subtitle"

        android:layout_width="0dp"

        android:layout_height="wrap_content"

        android:layout_weight="1"

        android:layout_marginStart="16dp"

        android:animateLayoutChanges="true"

        android:orientation="vertical">



        <TextView

src/com/android/packageinstaller/role/ui/RequestRoleFragment.java

+9 −0
Original line number Diff line number Diff line
@@ -295,6 +295,8 @@ public class RequestRoleFragment extends DialogFragment { 
        private static final String STATE_USER_CHECKED_PACKAGE_NAME = Adapter.class.getName()

                + ".state.USER_CHECKED_PACKAGE_NAME";



        private static final int LAYOUT_TRANSITION_DURATION_MILLIS = 150;



        @NonNull

        private final Role mRole;
@@ -482,6 +484,9 @@ public class RequestRoleFragment extends DialogFragment { 
                        false);

                holder = new ViewHolder(view);

                view.setTag(holder);



                holder.titleAndSubtitleLayout.getLayoutTransition().setDuration(

                        LAYOUT_TRANSITION_DURATION_MILLIS);

            }



            Pair<ApplicationInfo, Boolean> qualifyingApplication = getItem(position);
@@ -518,12 +523,16 @@ public class RequestRoleFragment extends DialogFragment { 
            @NonNull

            public final ImageView iconImage;

            @NonNull

            public final ViewGroup titleAndSubtitleLayout;

            @NonNull

            public final TextView titleText;

            @NonNull

            public final TextView subtitleText;



            ViewHolder(@NonNull View view) {

                iconImage = Objects.requireNonNull(view.findViewById(R.id.icon));

                titleAndSubtitleLayout = Objects.requireNonNull(view.findViewById(

                        R.id.title_and_subtitle));

                titleText = Objects.requireNonNull(view.findViewById(R.id.title));

                subtitleText = Objects.requireNonNull(view.findViewById(R.id.subtitle));

            }