Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d18b2612 authored by Joel Galenson's avatar Joel Galenson
Browse files

Fix a crash in AppPermissionUsageFragment. 

This fragment crashed immediately after leaving it.

I also fixed some repo upload check nits while I'm at it.

Test: View AppPermissionUsageFragment.
Change-Id: I80e4e74387c1e3ce66a468c11e7bec96ebc01ffb
parent 1ce1a950

src/com/android/packageinstaller/permission/model/PermissionUsages.java

+3 −1
Original line number Diff line number Diff line
@@ -27,15 +27,17 @@ import android.content.AsyncTaskLoader; 
import android.content.Context;

import android.content.Loader;

import android.os.Bundle;



import android.os.Process;

import android.util.ArrayMap;

import android.util.ArraySet;



import androidx.annotation.NonNull;

import androidx.annotation.Nullable;



import com.android.packageinstaller.permission.model.AppPermissionUsage.Builder;

import com.android.packageinstaller.permission.model.PermissionApps.PermissionApp;

import com.android.packageinstaller.permission.utils.Utils;



import java.util.ArrayList;

import java.util.Collections;

import java.util.List;

src/com/android/packageinstaller/permission/ui/handheld/AppPermissionUsageFragment.java

+7 −5
Original line number Diff line number Diff line
@@ -101,11 +101,10 @@ public class AppPermissionUsageFragment extends SettingsWithButtonHeader { 
            return;

        }



        final long endTimeMillis = System.currentTimeMillis() - TimeUnit.HOURS.toMillis(24);

        final long beginTimeMillis = System.currentTimeMillis() - TimeUnit.HOURS.toMillis(24);

        mPermissionUsages = new PermissionUsages(getContext());

        mPermissionUsages.load(packageName, null, 0 /*filterBeginTimeMillis*/,

                endTimeMillis, PermissionUsages.USAGE_FLAG_LAST

                        | PermissionUsages.USAGE_FLAG_HISTORICAL,

        mPermissionUsages.load(packageName, null, beginTimeMillis, Long.MAX_VALUE,

                PermissionUsages.USAGE_FLAG_LAST | PermissionUsages.USAGE_FLAG_HISTORICAL,

                getActivity().getLoaderManager(),

                true, this::updateUi);

    }
@@ -152,7 +151,10 @@ public class AppPermissionUsageFragment extends SettingsWithButtonHeader { 


        // Add the permission usages.

        final List<AppPermissionUsage> permissionUsages = mPermissionUsages.getUsages();

        if (permissionUsages.isEmpty() || permissionUsages.size() > 1) {

        if (permissionUsages.isEmpty()) {

            return;

        }

        if (permissionUsages.size() > 1) {

            Log.e(LOG_TAG, "Expected one AppPermissionUsage but got: " + permissionUsages);

            getActivity().finish();

            return;