Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 869786e3 authored by Svet Ganov's avatar Svet Ganov
Browse files

Fix a crash in package installer 

The first bug was that we were starting the install before
having the package info for the installed app. The second
was that we were calling the permission review UI despite
we were there before the user selected to install. i.e. the
user already reviewed the permissions.

bug:29197887

Change-Id: I2fac4d014dde7f7744a6b831c2b0ff510e29e8e8
parent cc5cd738

src/com/android/packageinstaller/InstallAppProgress.java

+0 −1
Original line number Diff line number Diff line
@@ -351,7 +351,6 @@ public class InstallAppProgress extends Activity implements View.OnClickListener 
            params.originatingUri = getIntent().getParcelableExtra(Intent.EXTRA_ORIGINATING_URI);

            params.originatingUid = getIntent().getIntExtra(Intent.EXTRA_ORIGINATING_UID,

                    UID_UNKNOWN);

            params.setInstallFlagsForcePermissionPrompt();



            mInstallHandler.post(new Runnable() {

                @Override

src/com/android/packageinstaller/PackageInstallerActivity.java

+1 −1
Original line number Diff line number Diff line
@@ -456,7 +456,7 @@ public class PackageInstallerActivity extends Activity implements OnCancelListen 
        // Block the install attempt on the Unknown Sources setting if necessary.

        final boolean requestFromUnknownSource = isInstallRequestFromUnknownSource(intent);

        if (!requestFromUnknownSource) {

            initiateInstall();

            processPackageUri(packageUri);

            return;

        }