Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 61afdfb5 authored by Dianne Hackborn's avatar Dianne Hackborn
Browse files

Fix issue #21945272: Crash in Activity.dispatchRequestPermissionsResult 

Make sure to send a full result no matter how we finish the activity.

Change-Id: Ic087a354053d0078985c33f6d1c77c9bb694dc62
parent 6304bd34

src/com/android/packageinstaller/permission/ui/GrantPermissionsActivity.java

+17 −8
Original line number Diff line number Diff line
@@ -64,6 +64,8 @@ public class GrantPermissionsActivity extends Activity 
    private GrantPermissionsViewHandler mViewHandler;

    private AppPermissions mAppPermissions;



    boolean mResultSet;



    @Override

    public void onCreate(Bundle icicle) {

        super.onCreate(icicle);
@@ -240,9 +242,9 @@ public class GrantPermissionsActivity extends Activity 
    }



    @Override

    public void onBackPressed() {

        setResultAndFinish();

        super.onBackPressed();

    public void finish() {

        setResultIfNeeded(RESULT_CANCELED);

        super.finish();

    }



    private int computePermissionGrantState(PackageInfo callingPackageInfo,
@@ -304,12 +306,19 @@ public class GrantPermissionsActivity extends Activity 
        }

    }



    private void setResultAndFinish() {

    private void setResultIfNeeded(int resultCode) {

        if (!mResultSet) {

            mResultSet = true;

            logRequestedPermissionGroups();

            Intent result = new Intent(PackageManager.ACTION_REQUEST_PERMISSIONS);

            result.putExtra(PackageManager.EXTRA_REQUEST_PERMISSIONS_NAMES, mRequestedPermissions);

            result.putExtra(PackageManager.EXTRA_REQUEST_PERMISSIONS_RESULTS, mGrantResults);

        setResult(RESULT_OK, result);

            setResult(resultCode, result);

        }

    }



    private void setResultAndFinish() {

        setResultIfNeeded(RESULT_OK);

        finish();

    }