Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4ee63a20 authored by Joel Galenson's avatar Joel Galenson
Browse files

Tweak AppPermissionFragment UI. 

Ensure the lower divider covers the entire screen and change the
header text so it does not repeat the app name.

Bug: 128439459
Test: View screen.
Change-Id: I3c32e74f64e82a3b0a59caefbe7adcf026d24d24
parent c4b7e139

res/values/strings.xml

+1 −1
Original line number Diff line number Diff line
@@ -386,7 +386,7 @@ 
    <string name="app_permission_title"><xliff:g id="perm" example="location">%1$s</xliff:g> permission</string>



    <!-- Description for showing an app's permission [CHAR LIMIT=60] -->

    <string name="app_permission_header"><xliff:g id="perm" example="location">%1$s</xliff:g> access for <xliff:g id="app" example="Maps">%2$s</xliff:g></string>

    <string name="app_permission_header"><xliff:g id="perm" example="location">%1$s</xliff:g> access for this app</string>



    <!-- Summary for showing a single permission access [CHAR LIMIT=60] -->

    <string name="app_permission_footer_usage_summary"><xliff:g id="app" example="Maps">%1$s</xliff:g> accessed your <xliff:g id="perm" example="location">%2$s</xliff:g> <xliff:g id="time" example="2 hours">%3$s</xliff:g> ago.</string>

res/values/styles.xml

+2 −2
Original line number Diff line number Diff line
@@ -264,8 +264,6 @@ 
        <item name="android:layout_height">wrap_content</item>

        <item name="android:orientation">vertical</item>

        <item name="android:minHeight">?android:attr/listPreferredItemHeight</item>

        <item name="android:paddingStart">?android:attr/listPreferredItemPaddingStart</item>

        <item name="android:paddingEnd">?android:attr/listPreferredItemPaddingEnd</item>

        <item name="android:background">?android:attr/selectableItemBackground</item>

    </style>
@@ -282,6 +280,8 @@ 
        <item name="android:paddingBottom">16dp</item>

        <item name="android:layout_marginStart">48dp</item>

        <item name="android:layout_marginEnd">48dp</item>

        <item name="android:paddingStart">?android:attr/listPreferredItemPaddingStart</item>

        <item name="android:paddingEnd">?android:attr/listPreferredItemPaddingEnd</item>

        <item name="android:textColor">?android:attr/textColorSecondary</item>

    </style>

src/com/android/packageinstaller/permission/ui/handheld/AppPermissionFragment.java

+1 −1
Original line number Diff line number Diff line
@@ -182,7 +182,7 @@ public class AppPermissionFragment extends SettingsWithLargeHeader { 
        updateHeader(root.requireViewById(R.id.large_header));



        ((TextView) root.requireViewById(R.id.permission_message)).setText(

                context.getString(R.string.app_permission_header, mGroup.getLabel(), appLabel));

                context.getString(R.string.app_permission_header, mGroup.getLabel()));



        if (Utils.isModernPermissionGroup(mGroup.getName())) {

            String timeDiffStr = Utils.getRelativeLastUsageString(context,