Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 42af15b6 authored by Svetoslav's avatar Svetoslav Committed by Svetoslav Ganov
Browse files

Fix some UI glitches in PackageInstaller 

1. Add missing tinting in ic_info.xml
2. Improve button stacking in the request permissions UI
3. Align text and icon in request permissions UI

bug:26071925

Change-Id: I12f631e902203d3f31970b28e420e20b7b454812
parent 2cf17ddc

res/drawable/ic_info.xml

+2 −1
Original line number Diff line number Diff line
@@ -17,7 +17,8 @@ Copyright (C) 2015 The Android Open Source Project 
        android:width="24.0dp"

        android:height="24.0dp"

        android:viewportWidth="24.0"

        android:viewportHeight="24.0">

        android:viewportHeight="24.0"

        android:tint="?attr/colorControlNormal">

    <path

        android:pathData="M0 0h24v24H0z"

        android:fillColor="#00000000"/>

res/layout/grant_permissions.xml

+23 −14
Original line number Diff line number Diff line
@@ -50,7 +50,7 @@ 
        <com.android.packageinstaller.permission.ui.ButtonBarLayout

            android:id="@+id/button_group"

            android:layout_width="match_parent"

            android:layout_height="wrap_content"

            android:layout_height="match_parent"

            android:orientation="horizontal"

            android:paddingStart="2dip"

            android:paddingTop="16dip">
@@ -59,6 +59,7 @@ 
                android:id="@+id/current_page_text"

                android:layout_width="wrap_content"

                android:layout_height="wrap_content"

                android:layout_gravity="start|bottom"

                android:paddingTop="4dp"

                android:paddingBottom="4dp"

                android:paddingEnd="12dp"
@@ -76,6 +77,12 @@ 
                android:visibility="invisible" >

            </Space>



            <LinearLayout

                android:layout_width="wrap_content"

                android:layout_height="wrap_content"

                android:layout_gravity="end"

                android:orientation="horizontal" >



                <Button

                    android:id="@+id/permission_deny_button"

                    android:layout_width="wrap_content"
@@ -93,6 +100,8 @@ 
                    android:text="@string/grant_dialog_button_allow" >

                </Button>



            </LinearLayout>



        </com.android.packageinstaller.permission.ui.ButtonBarLayout>



    </LinearLayout>

res/layout/permission_description.xml

+1 −0
Original line number Diff line number Diff line
@@ -34,6 +34,7 @@ 
        android:layout_width="wrap_content"

        android:layout_height="wrap_content"

        android:layout_toRightOf="@id/permission_icon"

        android:layout_marginTop="3dp"

        android:paddingStart="16dip"

        android:paddingEnd="8dip"

        style="?android:attr/textAppearanceMedium">