Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 35d169d0 authored by Joel Galenson's avatar Joel Galenson
Browse files

Properly check that usages are in the correct time range. 

In addition to passing the time range to the API that returns the
usages, we also have to check that the returned usages are within the
time period.  Not doing this caused users of this API to show
incorrect results.

Test: See that Settings and PermissionsController have the same values
in their bar charts.

Change-Id: I5f39881dc8df04f9c954fb4b1102737fdd6aad6d
parent 15bf2f66

src/com/android/packageinstaller/permission/service/PermissionControllerServiceImpl.java

+2 −5
Original line number Diff line number Diff line
@@ -455,16 +455,13 @@ public final class PermissionControllerServiceImpl extends PermissionControllerS 
        for (int appNum = 0; appNum < numApps; appNum++) {

            AppPermissionUsage appPermissionUsage = appPermissionUsages.get(appNum);



            if (appPermissionUsage.getAccessCount() <= 0) {

                continue;

            }



            List<GroupUsage> appGroups = appPermissionUsage.getGroupUsages();

            int numGroups = appGroups.size();

            for (int groupNum = 0; groupNum < numGroups; groupNum++) {

                GroupUsage groupUsage = appGroups.get(groupNum);



                if (groupUsage.getAccessCount() <= 0) {

                if (groupUsage.getAccessCount() <= 0

                        || groupUsage.getLastAccessTime() < filterTimeBeginMillis) {

                    continue;

                }

                if (!shouldShowPermission(this, groupUsage.getGroup())) {