Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 25e686d3 authored by Todd Kennedy's avatar Todd Kennedy Committed by Atanas Kirilov
Browse files

RESTRICT AUTOMERGE: Always use safe labels 

For display purposes, we should always be using safe labels. This
prevents excessively long labels from preventing app uninstallation.

Bug: 62537081
Test: Manual. Install APK from bug and see that it can be uninstalled
Change-Id: Ic0e0d47f5ff76e4a73b30988d0a024fb3ee651ae
parent 41c646ac

src/com/android/packageinstaller/UninstallerActivity.java

+2 −2
Original line number Diff line number Diff line
@@ -56,7 +56,7 @@ public class UninstallerActivity extends Activity { 
        public Dialog onCreateDialog(Bundle savedInstanceState) {

            final PackageManager pm = getActivity().getPackageManager();

            final DialogInfo dialogInfo = ((UninstallerActivity) getActivity()).mDialogInfo;

            final CharSequence appLabel = dialogInfo.appInfo.loadLabel(pm);

            final CharSequence appLabel = dialogInfo.appInfo.loadSafeLabel(pm);



            AlertDialog.Builder dialogBuilder = new AlertDialog.Builder(getActivity());

            StringBuilder messageBuilder = new StringBuilder();
@@ -64,7 +64,7 @@ public class UninstallerActivity extends Activity { 
            // If the Activity label differs from the App label, then make sure the user

            // knows the Activity belongs to the App being uninstalled.

            if (dialogInfo.activityInfo != null) {

                final CharSequence activityLabel = dialogInfo.activityInfo.loadLabel(pm);

                final CharSequence activityLabel = dialogInfo.activityInfo.loadSafeLabel(pm);

                if (!activityLabel.equals(appLabel)) {

                    messageBuilder.append(

                            getString(R.string.uninstall_activity_text, activityLabel));