From 65f1e25d4ccbdfd9d122820227dc0a20fd5973ed Mon Sep 17 00:00:00 2001 From: mohit mali Date: Tue, 2 Mar 2021 15:31:52 +0530 Subject: [PATCH 01/17] Added url ota url and code to get developer option status --- res/values/strings.xml | 1 + src/org/lineageos/updater/misc/Utils.java | 17 ++++++++++++++++- 2 files changed, 17 insertions(+), 1 deletion(-) diff --git a/res/values/strings.xml b/res/values/strings.xml index 6bcba24d..b2c906ad 100644 --- a/res/values/strings.xml +++ b/res/values/strings.xml @@ -33,6 +33,7 @@ {incr} - Incremental version --> https://ota.ecloud.global/api/v1/{device}/{type}/{incr} + https://test.ota.ecloud.global/api/v1/{device}/{type}/{incr} Verification failed Verifying update diff --git a/src/org/lineageos/updater/misc/Utils.java b/src/org/lineageos/updater/misc/Utils.java index d8022ac8..b4dcfa1c 100644 --- a/src/org/lineageos/updater/misc/Utils.java +++ b/src/org/lineageos/updater/misc/Utils.java @@ -22,8 +22,10 @@ import android.content.Context; import android.content.Intent; import android.content.SharedPreferences; import android.content.pm.PackageManager; +import android.database.Cursor; import android.net.ConnectivityManager; import android.net.NetworkInfo; +import android.net.Uri; import android.os.Environment; import android.os.SystemProperties; import android.os.storage.StorageManager; @@ -187,13 +189,26 @@ public class Utils { String serverUrl = SystemProperties.get(Constants.PROP_UPDATER_URI); if (serverUrl.trim().isEmpty()) { serverUrl = context.getString(R.string.updater_server_url); + serverUrl = context.getString(R.string.ota_staging_server_url); } - + Log.e(TAG, "getServerURL: "+retrieveStatus(context) ); return serverUrl.replace("{device}", device) .replace("{type}", type) .replace("{incr}", incrementalVersion); } + public static String retrieveStatus(Context context) { + String status = null; + Cursor c = context.getContentResolver().query(Uri.parse("content://custom.setting.Provider.OTA_SERVER/cte"), null, "id=?", new String[]{"1"}, "Status"); + if (c.moveToFirst()) { + do { + status = c.getString(c.getColumnIndex("Status")); + android.util.Log.e("TAG", "retrieveStatus: " + c.getString(c.getColumnIndex("Status"))); + } while (c.moveToNext()); + } + return status; + } + public static String getUpgradeBlockedURL(Context context) { String device = SystemProperties.get(Constants.PROP_NEXT_DEVICE, SystemProperties.get(Constants.PROP_DEVICE)); -- GitLab From 4788a569503db4eb53c81ec683b50dd3ba997687 Mon Sep 17 00:00:00 2001 From: mohit mali Date: Tue, 2 Mar 2021 16:50:13 +0530 Subject: [PATCH 02/17] Implemented logic to change url from developer options --- src/org/lineageos/updater/misc/Utils.java | 35 ++++++++++++++--------- 1 file changed, 22 insertions(+), 13 deletions(-) diff --git a/src/org/lineageos/updater/misc/Utils.java b/src/org/lineageos/updater/misc/Utils.java index b4dcfa1c..b6ac3940 100644 --- a/src/org/lineageos/updater/misc/Utils.java +++ b/src/org/lineageos/updater/misc/Utils.java @@ -103,16 +103,16 @@ public class Utils { int[] updateVersionParts = parseSemVer(update.getVersion()); int updateMajorVersion = updateVersionParts[0]; int updateMinorVersion = updateVersionParts[1]; - Log.d(TAG, "Update : Major "+updateMajorVersion +" Minor "+ updateMinorVersion ); + Log.d(TAG, "Update : Major " + updateMajorVersion + " Minor " + updateMinorVersion); int[] deviceVersionParts = parseSemVer(SystemProperties.get(Constants.PROP_BUILD_VERSION)); int deviceMajorVersion = deviceVersionParts[0]; int deviceMinorVersion = deviceVersionParts[1]; - Log.d(TAG, "Device : Major "+ deviceMajorVersion +" Minor "+ deviceMinorVersion ); + Log.d(TAG, "Device : Major " + deviceMajorVersion + " Minor " + deviceMinorVersion); if (!SystemProperties.getBoolean(Constants.PROP_UPDATER_ALLOW_DOWNGRADING, false) && - update.getTimestamp() <= SystemProperties.getLong(Constants.PROP_BUILD_DATE, 0)) { + update.getTimestamp() <= SystemProperties.getLong(Constants.PROP_BUILD_DATE, 0)) { Log.d(TAG, update.getName() + " is older than/equal to the current build"); return false; } @@ -120,15 +120,15 @@ public class Utils { Log.d(TAG, update.getName() + " has type " + update.getType()); return false; } - if(updateMajorVersion > deviceMajorVersion){ + if (updateMajorVersion > deviceMajorVersion) { Log.d(TAG, update.getName() + " is Newer to current Major version"); return true; } - if(updateMajorVersion < deviceMajorVersion){ + if (updateMajorVersion < deviceMajorVersion) { Log.d(TAG, update.getName() + " is Older to current Major version"); return false; } - if(updateMinorVersion < deviceMinorVersion){ + if (updateMinorVersion < deviceMinorVersion) { Log.d(TAG, update.getName() + " is Older to current Minor version"); return false; } @@ -140,7 +140,7 @@ public class Utils { String[] versionParts = versionCode.split(Pattern.quote(".")); int major = Integer.parseInt(versionParts[0]); int minor = Integer.parseInt(versionParts[1]); - return new int[]{ major, minor }; + return new int[]{major, minor}; } public static boolean canInstall(UpdateBaseInfo update) { @@ -154,7 +154,7 @@ public class Utils { String json = ""; try (BufferedReader br = new BufferedReader(new FileReader(file))) { - for (String line; (line = br.readLine()) != null;) { + for (String line; (line = br.readLine()) != null; ) { json += line; } } @@ -186,12 +186,21 @@ public class Utils { SystemProperties.get(Constants.PROP_DEVICE)); String type = SystemProperties.get(Constants.PROP_RELEASE_TYPE).toLowerCase(Locale.ROOT); - String serverUrl = SystemProperties.get(Constants.PROP_UPDATER_URI); + String serverUrl = ""; + if (retrieveStatus(context).equals("true")) { + + serverUrl = context.getString(R.string.ota_staging_server_url); + + return serverUrl.replace("{device}", device) + .replace("{type}", type) + .replace("{incr}", incrementalVersion); + } else { + serverUrl = SystemProperties.get(Constants.PROP_UPDATER_URI); + } + if (serverUrl.trim().isEmpty()) { serverUrl = context.getString(R.string.updater_server_url); - serverUrl = context.getString(R.string.ota_staging_server_url); } - Log.e(TAG, "getServerURL: "+retrieveStatus(context) ); return serverUrl.replace("{device}", device) .replace("{type}", type) .replace("{incr}", incrementalVersion); @@ -199,7 +208,7 @@ public class Utils { public static String retrieveStatus(Context context) { String status = null; - Cursor c = context.getContentResolver().query(Uri.parse("content://custom.setting.Provider.OTA_SERVER/cte"), null, "id=?", new String[]{"1"}, "Status"); + Cursor c = context.getContentResolver().query(Uri.parse("content://custom.setting.Provider.OTA_SERVER/cte"), null, "id=?", new String[]{"1"}, "Status"); if (c.moveToFirst()) { do { status = c.getString(c.getColumnIndex("Status")); @@ -273,7 +282,7 @@ public class Utils { /** * Get the offset to the compressed data of a file inside the given zip * - * @param zipFile input zip file + * @param zipFile input zip file * @param entryPath full path of the entry * @return the offset of the compressed, or -1 if not found * @throws IllegalArgumentException if the given entry is not found -- GitLab From 4aa172bdf6bc0b07230c0b309fd1da00bf57a172 Mon Sep 17 00:00:00 2001 From: mohit mali Date: Tue, 2 Mar 2021 18:05:15 +0530 Subject: [PATCH 03/17] Implemented logic to change url from developer options also put check for null --- src/org/lineageos/updater/misc/Utils.java | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/org/lineageos/updater/misc/Utils.java b/src/org/lineageos/updater/misc/Utils.java index b6ac3940..dca625d4 100644 --- a/src/org/lineageos/updater/misc/Utils.java +++ b/src/org/lineageos/updater/misc/Utils.java @@ -187,9 +187,9 @@ public class Utils { String type = SystemProperties.get(Constants.PROP_RELEASE_TYPE).toLowerCase(Locale.ROOT); String serverUrl = ""; - if (retrieveStatus(context).equals("true")) { - - serverUrl = context.getString(R.string.ota_staging_server_url); + if (retrieveStatus(context) != null) { + if (retrieveStatus(context).equals("true")) + serverUrl = context.getString(R.string.ota_staging_server_url); return serverUrl.replace("{device}", device) .replace("{type}", type) @@ -212,7 +212,6 @@ public class Utils { if (c.moveToFirst()) { do { status = c.getString(c.getColumnIndex("Status")); - android.util.Log.e("TAG", "retrieveStatus: " + c.getString(c.getColumnIndex("Status"))); } while (c.moveToNext()); } return status; -- GitLab From 659c3277a49c6b3ebca920fa79d9ae1792b875aa Mon Sep 17 00:00:00 2001 From: mohit mali Date: Wed, 3 Mar 2021 09:32:09 +0530 Subject: [PATCH 04/17] Implemented logic to change url from developer options also put check for null --- src/org/lineageos/updater/misc/Utils.java | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/src/org/lineageos/updater/misc/Utils.java b/src/org/lineageos/updater/misc/Utils.java index dca625d4..960cf78a 100644 --- a/src/org/lineageos/updater/misc/Utils.java +++ b/src/org/lineageos/updater/misc/Utils.java @@ -188,12 +188,15 @@ public class Utils { String serverUrl = ""; if (retrieveStatus(context) != null) { - if (retrieveStatus(context).equals("true")) + if (retrieveStatus(context).equals("true")) { serverUrl = context.getString(R.string.ota_staging_server_url); - return serverUrl.replace("{device}", device) - .replace("{type}", type) - .replace("{incr}", incrementalVersion); + return serverUrl.replace("{device}", device) + .replace("{type}", type) + .replace("{incr}", incrementalVersion); + }else{ + serverUrl = SystemProperties.get(Constants.PROP_UPDATER_URI); + } } else { serverUrl = SystemProperties.get(Constants.PROP_UPDATER_URI); } -- GitLab From 8a04511a3bcaeaec1f46574de69a76789991aacc Mon Sep 17 00:00:00 2001 From: mohit mali Date: Thu, 18 Mar 2021 15:32:21 +0530 Subject: [PATCH 05/17] Implemented suggestion --- src/org/lineageos/updater/misc/Utils.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/org/lineageos/updater/misc/Utils.java b/src/org/lineageos/updater/misc/Utils.java index 960cf78a..c333096b 100644 --- a/src/org/lineageos/updater/misc/Utils.java +++ b/src/org/lineageos/updater/misc/Utils.java @@ -208,7 +208,7 @@ public class Utils { .replace("{type}", type) .replace("{incr}", incrementalVersion); } - + /*retrieve status from database of ota option is on or off*/ public static String retrieveStatus(Context context) { String status = null; Cursor c = context.getContentResolver().query(Uri.parse("content://custom.setting.Provider.OTA_SERVER/cte"), null, "id=?", new String[]{"1"}, "Status"); -- GitLab From 47a3aeaf3972e428cdcfc4974489d5505882277f Mon Sep 17 00:00:00 2001 From: Romain Hunault Date: Fri, 2 Apr 2021 14:44:36 +0000 Subject: [PATCH 06/17] Apply 1 suggestion(s) to 1 file(s) --- src/org/lineageos/updater/misc/Utils.java | 1 + 1 file changed, 1 insertion(+) diff --git a/src/org/lineageos/updater/misc/Utils.java b/src/org/lineageos/updater/misc/Utils.java index c333096b..f4996e6d 100644 --- a/src/org/lineageos/updater/misc/Utils.java +++ b/src/org/lineageos/updater/misc/Utils.java @@ -1,5 +1,6 @@ /* * Copyright (C) 2017 The LineageOS Project + * Copyright (C) 2021 ECORP SAS * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. -- GitLab From cc9ecb4b8a134f595236a8ba7f7cb2f40eb3f2bf Mon Sep 17 00:00:00 2001 From: Romain Hunault Date: Fri, 2 Apr 2021 14:45:19 +0000 Subject: [PATCH 07/17] Apply 1 suggestion(s) to 1 file(s) --- src/org/lineageos/updater/misc/Utils.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/org/lineageos/updater/misc/Utils.java b/src/org/lineageos/updater/misc/Utils.java index f4996e6d..bc94e6c0 100644 --- a/src/org/lineageos/updater/misc/Utils.java +++ b/src/org/lineageos/updater/misc/Utils.java @@ -113,7 +113,7 @@ public class Utils { if (!SystemProperties.getBoolean(Constants.PROP_UPDATER_ALLOW_DOWNGRADING, false) && - update.getTimestamp() <= SystemProperties.getLong(Constants.PROP_BUILD_DATE, 0)) { + update.getTimestamp() <= SystemProperties.getLong(Constants.PROP_BUILD_DATE, 0)) { Log.d(TAG, update.getName() + " is older than/equal to the current build"); return false; } -- GitLab From 0d49f5be4ffd6f23a8c4e9d1fff2c9d68cbd6868 Mon Sep 17 00:00:00 2001 From: Romain Hunault Date: Fri, 2 Apr 2021 14:46:19 +0000 Subject: [PATCH 08/17] Apply 1 suggestion(s) to 1 file(s) --- src/org/lineageos/updater/misc/Utils.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/org/lineageos/updater/misc/Utils.java b/src/org/lineageos/updater/misc/Utils.java index bc94e6c0..93dfa21d 100644 --- a/src/org/lineageos/updater/misc/Utils.java +++ b/src/org/lineageos/updater/misc/Utils.java @@ -125,7 +125,7 @@ public class Utils { Log.d(TAG, update.getName() + " is Newer to current Major version"); return true; } - if (updateMajorVersion < deviceMajorVersion) { + if(updateMajorVersion < deviceMajorVersion){ Log.d(TAG, update.getName() + " is Older to current Major version"); return false; } -- GitLab From 181320e8342de718214596cf963e9aaa2c59bf85 Mon Sep 17 00:00:00 2001 From: Romain Hunault Date: Fri, 2 Apr 2021 14:46:39 +0000 Subject: [PATCH 09/17] Apply 1 suggestion(s) to 1 file(s) --- src/org/lineageos/updater/misc/Utils.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/org/lineageos/updater/misc/Utils.java b/src/org/lineageos/updater/misc/Utils.java index 93dfa21d..95b13059 100644 --- a/src/org/lineageos/updater/misc/Utils.java +++ b/src/org/lineageos/updater/misc/Utils.java @@ -121,7 +121,7 @@ public class Utils { Log.d(TAG, update.getName() + " has type " + update.getType()); return false; } - if (updateMajorVersion > deviceMajorVersion) { + if(updateMajorVersion > deviceMajorVersion){ Log.d(TAG, update.getName() + " is Newer to current Major version"); return true; } -- GitLab From f8817be25e0944455d2d405ba80e826b2729c685 Mon Sep 17 00:00:00 2001 From: Romain Hunault Date: Fri, 2 Apr 2021 14:46:44 +0000 Subject: [PATCH 10/17] Apply 1 suggestion(s) to 1 file(s) --- src/org/lineageos/updater/misc/Utils.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/org/lineageos/updater/misc/Utils.java b/src/org/lineageos/updater/misc/Utils.java index 95b13059..ac4db70f 100644 --- a/src/org/lineageos/updater/misc/Utils.java +++ b/src/org/lineageos/updater/misc/Utils.java @@ -129,7 +129,7 @@ public class Utils { Log.d(TAG, update.getName() + " is Older to current Major version"); return false; } - if (updateMinorVersion < deviceMinorVersion) { + if(updateMinorVersion < deviceMinorVersion){ Log.d(TAG, update.getName() + " is Older to current Minor version"); return false; } -- GitLab From 81669ca24f28f4804c279be1e906dcbbefd265f8 Mon Sep 17 00:00:00 2001 From: Romain Hunault Date: Fri, 2 Apr 2021 14:47:33 +0000 Subject: [PATCH 11/17] Apply 1 suggestion(s) to 1 file(s) --- src/org/lineageos/updater/misc/Utils.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/org/lineageos/updater/misc/Utils.java b/src/org/lineageos/updater/misc/Utils.java index ac4db70f..d0c21bbd 100644 --- a/src/org/lineageos/updater/misc/Utils.java +++ b/src/org/lineageos/updater/misc/Utils.java @@ -141,7 +141,7 @@ public class Utils { String[] versionParts = versionCode.split(Pattern.quote(".")); int major = Integer.parseInt(versionParts[0]); int minor = Integer.parseInt(versionParts[1]); - return new int[]{major, minor}; + return new int[]{ major, minor }; } public static boolean canInstall(UpdateBaseInfo update) { -- GitLab From 29fa2a7ca130f4b0ab9f5d81ad4f9a0d39f61a36 Mon Sep 17 00:00:00 2001 From: Romain Hunault Date: Fri, 2 Apr 2021 14:47:36 +0000 Subject: [PATCH 12/17] Apply 1 suggestion(s) to 1 file(s) --- src/org/lineageos/updater/misc/Utils.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/org/lineageos/updater/misc/Utils.java b/src/org/lineageos/updater/misc/Utils.java index d0c21bbd..adfbab58 100644 --- a/src/org/lineageos/updater/misc/Utils.java +++ b/src/org/lineageos/updater/misc/Utils.java @@ -155,7 +155,7 @@ public class Utils { String json = ""; try (BufferedReader br = new BufferedReader(new FileReader(file))) { - for (String line; (line = br.readLine()) != null; ) { + for (String line; (line = br.readLine()) != null;) { json += line; } } -- GitLab From 321f9fba91574299cd8330cb545474a5ddffecbd Mon Sep 17 00:00:00 2001 From: Romain Hunault Date: Fri, 2 Apr 2021 14:48:05 +0000 Subject: [PATCH 13/17] Apply 1 suggestion(s) to 1 file(s) --- src/org/lineageos/updater/misc/Utils.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/org/lineageos/updater/misc/Utils.java b/src/org/lineageos/updater/misc/Utils.java index adfbab58..8b7ecc94 100644 --- a/src/org/lineageos/updater/misc/Utils.java +++ b/src/org/lineageos/updater/misc/Utils.java @@ -285,7 +285,7 @@ public class Utils { /** * Get the offset to the compressed data of a file inside the given zip * - * @param zipFile input zip file + * @param zipFile input zip file * @param entryPath full path of the entry * @return the offset of the compressed, or -1 if not found * @throws IllegalArgumentException if the given entry is not found -- GitLab From 932764a33db01f3113da0e9b28f73a1218e13379 Mon Sep 17 00:00:00 2001 From: Romain Hunault Date: Fri, 2 Apr 2021 14:48:47 +0000 Subject: [PATCH 14/17] Apply 1 suggestion(s) to 1 file(s) --- src/org/lineageos/updater/misc/Utils.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/org/lineageos/updater/misc/Utils.java b/src/org/lineageos/updater/misc/Utils.java index 8b7ecc94..c3bf91fd 100644 --- a/src/org/lineageos/updater/misc/Utils.java +++ b/src/org/lineageos/updater/misc/Utils.java @@ -104,7 +104,7 @@ public class Utils { int[] updateVersionParts = parseSemVer(update.getVersion()); int updateMajorVersion = updateVersionParts[0]; int updateMinorVersion = updateVersionParts[1]; - Log.d(TAG, "Update : Major " + updateMajorVersion + " Minor " + updateMinorVersion); + Log.d(TAG, "Update : Major "+ updateMajorVersion +" Minor "+ updateMinorVersion); int[] deviceVersionParts = parseSemVer(SystemProperties.get(Constants.PROP_BUILD_VERSION)); int deviceMajorVersion = deviceVersionParts[0]; -- GitLab From 6a8af455bbbf016db6ee0e1075a4af9486bb6e2b Mon Sep 17 00:00:00 2001 From: Romain Hunault Date: Fri, 2 Apr 2021 14:48:51 +0000 Subject: [PATCH 15/17] Apply 1 suggestion(s) to 1 file(s) --- src/org/lineageos/updater/misc/Utils.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/org/lineageos/updater/misc/Utils.java b/src/org/lineageos/updater/misc/Utils.java index c3bf91fd..87e59117 100644 --- a/src/org/lineageos/updater/misc/Utils.java +++ b/src/org/lineageos/updater/misc/Utils.java @@ -109,7 +109,7 @@ public class Utils { int[] deviceVersionParts = parseSemVer(SystemProperties.get(Constants.PROP_BUILD_VERSION)); int deviceMajorVersion = deviceVersionParts[0]; int deviceMinorVersion = deviceVersionParts[1]; - Log.d(TAG, "Device : Major " + deviceMajorVersion + " Minor " + deviceMinorVersion); + Log.d(TAG, "Device : Major "+ deviceMajorVersion +" Minor "+ deviceMinorVersion); if (!SystemProperties.getBoolean(Constants.PROP_UPDATER_ALLOW_DOWNGRADING, false) && -- GitLab From 4f99eb04b80af585c8bbd8941e95cf9989dfb2a9 Mon Sep 17 00:00:00 2001 From: Romain Hunault Date: Fri, 2 Apr 2021 14:49:48 +0000 Subject: [PATCH 16/17] Apply 1 suggestion(s) to 1 file(s) --- src/org/lineageos/updater/misc/Utils.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/org/lineageos/updater/misc/Utils.java b/src/org/lineageos/updater/misc/Utils.java index 87e59117..265cc3c6 100644 --- a/src/org/lineageos/updater/misc/Utils.java +++ b/src/org/lineageos/updater/misc/Utils.java @@ -104,7 +104,7 @@ public class Utils { int[] updateVersionParts = parseSemVer(update.getVersion()); int updateMajorVersion = updateVersionParts[0]; int updateMinorVersion = updateVersionParts[1]; - Log.d(TAG, "Update : Major "+ updateMajorVersion +" Minor "+ updateMinorVersion); + Log.d(TAG, "Update : Major "+updateMajorVersion +" Minor "+ updateMinorVersion ); int[] deviceVersionParts = parseSemVer(SystemProperties.get(Constants.PROP_BUILD_VERSION)); int deviceMajorVersion = deviceVersionParts[0]; -- GitLab From 7ebbd1c0697a433c95b2adf4936f1869e8e8fe93 Mon Sep 17 00:00:00 2001 From: Romain Hunault Date: Fri, 2 Apr 2021 14:49:56 +0000 Subject: [PATCH 17/17] Apply 1 suggestion(s) to 1 file(s) --- src/org/lineageos/updater/misc/Utils.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/org/lineageos/updater/misc/Utils.java b/src/org/lineageos/updater/misc/Utils.java index 265cc3c6..ae531d45 100644 --- a/src/org/lineageos/updater/misc/Utils.java +++ b/src/org/lineageos/updater/misc/Utils.java @@ -109,7 +109,7 @@ public class Utils { int[] deviceVersionParts = parseSemVer(SystemProperties.get(Constants.PROP_BUILD_VERSION)); int deviceMajorVersion = deviceVersionParts[0]; int deviceMinorVersion = deviceVersionParts[1]; - Log.d(TAG, "Device : Major "+ deviceMajorVersion +" Minor "+ deviceMinorVersion); + Log.d(TAG, "Device : Major "+ deviceMajorVersion +" Minor "+ deviceMinorVersion ); if (!SystemProperties.getBoolean(Constants.PROP_UPDATER_ALLOW_DOWNGRADING, false) && -- GitLab