From 4c5240751fd7667bf5c6e44be6124ae6651b69a8 Mon Sep 17 00:00:00 2001 From: althafvly Date: Tue, 17 Sep 2024 21:24:30 +0530 Subject: [PATCH 1/2] Revert "Updater: Force performance mode for FP4 and FP5" This reverts commit 98d44aff21eee2971e4e7d2b39b46e8b5ae3f4ac. --- .../main/java/org/lineageos/updater/UpdatesActivity.java | 5 ----- .../org/lineageos/updater/controller/ABUpdateInstaller.java | 2 +- app/src/main/java/org/lineageos/updater/misc/Utils.java | 6 ------ 3 files changed, 1 insertion(+), 12 deletions(-) diff --git a/app/src/main/java/org/lineageos/updater/UpdatesActivity.java b/app/src/main/java/org/lineageos/updater/UpdatesActivity.java index ca9d228e..d9d4aea2 100644 --- a/app/src/main/java/org/lineageos/updater/UpdatesActivity.java +++ b/app/src/main/java/org/lineageos/updater/UpdatesActivity.java @@ -630,11 +630,6 @@ public class UpdatesActivity extends UpdatesListActivity implements UpdateImport abPerfMode.setChecked(prefs.getBoolean(Constants.PREF_AB_PERF_MODE, getResources().getBoolean(R.bool.config_prioritizeUpdateProcess))); - if (Utils.isPrefDevices()) { - abPerfMode.setChecked(true); - abPerfMode.setEnabled(false); - } - if (getResources().getBoolean(R.bool.config_hideRecoveryUpdate)) { // Hide the update feature if explicitly requested. // Might be the case of A-only devices using prebuilt vendor images. diff --git a/app/src/main/java/org/lineageos/updater/controller/ABUpdateInstaller.java b/app/src/main/java/org/lineageos/updater/controller/ABUpdateInstaller.java index 2fe66473..535f984e 100644 --- a/app/src/main/java/org/lineageos/updater/controller/ABUpdateInstaller.java +++ b/app/src/main/java/org/lineageos/updater/controller/ABUpdateInstaller.java @@ -210,7 +210,7 @@ class ABUpdateInstaller { boolean enableABPerfMode = PreferenceManager.getDefaultSharedPreferences(mContext) .getBoolean(Constants.PREF_AB_PERF_MODE, false); - mUpdateEngine.setPerformanceMode(enableABPerfMode || Utils.isPrefDevices()); + mUpdateEngine.setPerformanceMode(enableABPerfMode); String zipFileUri = "file://" + file.getAbsolutePath(); try { diff --git a/app/src/main/java/org/lineageos/updater/misc/Utils.java b/app/src/main/java/org/lineageos/updater/misc/Utils.java index 209796cc..8be60282 100644 --- a/app/src/main/java/org/lineageos/updater/misc/Utils.java +++ b/app/src/main/java/org/lineageos/updater/misc/Utils.java @@ -543,12 +543,6 @@ public class Utils { return isAB; } - public static boolean isPrefDevices() { - String manufacturer = Build.MANUFACTURER.toLowerCase(Locale.ROOT); - String device = Build.DEVICE.toLowerCase(Locale.ROOT); - return manufacturer.equals("fairphone") && (device.equals("fp4") || device.equals("fp5")); - } - public static boolean isDevModeOn(Context context) { return Settings.Secure.getInt(context.getContentResolver(), Settings.Global.DEVELOPMENT_SETTINGS_ENABLED , 0) == 1; -- GitLab From 17c9ea3bb440f7705c3c2f50e11a0477bd185c00 Mon Sep 17 00:00:00 2001 From: althafvly Date: Tue, 17 Sep 2024 21:21:51 +0530 Subject: [PATCH 2/2] Updater: Change preference to reset default value --- .../main/java/org/lineageos/updater/UpdatesActivity.java | 2 +- .../lineageos/updater/controller/ABUpdateInstaller.java | 2 +- .../main/java/org/lineageos/updater/misc/Constants.java | 3 ++- app/src/main/java/org/lineageos/updater/misc/Utils.java | 7 +++++++ 4 files changed, 11 insertions(+), 3 deletions(-) diff --git a/app/src/main/java/org/lineageos/updater/UpdatesActivity.java b/app/src/main/java/org/lineageos/updater/UpdatesActivity.java index d9d4aea2..dfc13163 100644 --- a/app/src/main/java/org/lineageos/updater/UpdatesActivity.java +++ b/app/src/main/java/org/lineageos/updater/UpdatesActivity.java @@ -628,7 +628,7 @@ public class UpdatesActivity extends UpdatesListActivity implements UpdateImport meteredNetworkWarning.setChecked(prefs.getBoolean(Constants.PREF_METERED_NETWORK_WARNING, prefs.getBoolean(Constants.PREF_MOBILE_DATA_WARNING, true))); abPerfMode.setChecked(prefs.getBoolean(Constants.PREF_AB_PERF_MODE, - getResources().getBoolean(R.bool.config_prioritizeUpdateProcess))); + Utils.defaultABPerfMode(this))); if (getResources().getBoolean(R.bool.config_hideRecoveryUpdate)) { // Hide the update feature if explicitly requested. diff --git a/app/src/main/java/org/lineageos/updater/controller/ABUpdateInstaller.java b/app/src/main/java/org/lineageos/updater/controller/ABUpdateInstaller.java index 535f984e..380eba21 100644 --- a/app/src/main/java/org/lineageos/updater/controller/ABUpdateInstaller.java +++ b/app/src/main/java/org/lineageos/updater/controller/ABUpdateInstaller.java @@ -209,7 +209,7 @@ class ABUpdateInstaller { } boolean enableABPerfMode = PreferenceManager.getDefaultSharedPreferences(mContext) - .getBoolean(Constants.PREF_AB_PERF_MODE, false); + .getBoolean(Constants.PREF_AB_PERF_MODE, Utils.defaultABPerfMode(mContext)); mUpdateEngine.setPerformanceMode(enableABPerfMode); String zipFileUri = "file://" + file.getAbsolutePath(); diff --git a/app/src/main/java/org/lineageos/updater/misc/Constants.java b/app/src/main/java/org/lineageos/updater/misc/Constants.java index 5c38037a..56525dba 100644 --- a/app/src/main/java/org/lineageos/updater/misc/Constants.java +++ b/app/src/main/java/org/lineageos/updater/misc/Constants.java @@ -35,7 +35,8 @@ public final class Constants { public static final String PREF_AUTO_UPDATES_CHECK_INTERVAL = "auto_updates_check_interval"; public static final String PREF_AUTO_DELETE_UPDATES = "auto_delete_updates"; public static final String PREF_ALL_UPDATES = "all_updates"; - public static final String PREF_AB_PERF_MODE = "ab_perf_mode"; + public static final String PREF_AB_PERF_MODE_OLD = "ab_perf_mode"; + public static final String PREF_AB_PERF_MODE = "e_ab_perf_mode"; public static final String PREF_METERED_NETWORK_WARNING = "pref_metered_network_warning"; public static final String PREF_MOBILE_DATA_WARNING = "pref_mobile_data_warning"; public static final String PREF_NEEDS_REBOOT_ID = "needs_reboot_id"; diff --git a/app/src/main/java/org/lineageos/updater/misc/Utils.java b/app/src/main/java/org/lineageos/updater/misc/Utils.java index 8be60282..656aef05 100644 --- a/app/src/main/java/org/lineageos/updater/misc/Utils.java +++ b/app/src/main/java/org/lineageos/updater/misc/Utils.java @@ -543,6 +543,13 @@ public class Utils { return isAB; } + public static boolean defaultABPerfMode(Context context) { + SharedPreferences prefs = PreferenceManager.getDefaultSharedPreferences(context); + boolean oldPrefValue = prefs.getBoolean(Constants.PREF_AB_PERF_MODE_OLD, false); + return (context.getResources().getBoolean(R.bool.config_prioritizeUpdateProcess) + || oldPrefValue); + } + public static boolean isDevModeOn(Context context) { return Settings.Secure.getInt(context.getContentResolver(), Settings.Global.DEVELOPMENT_SETTINGS_ENABLED , 0) == 1; -- GitLab