From 1e58ec33fc92bb822fda91d79ecdc636bbab471e Mon Sep 17 00:00:00 2001
From: Nishith Khanna <nishithkhanna@e.email>
Date: Thu, 19 Oct 2023 12:51:36 +0530
Subject: [PATCH] Make ui improvements in update list

- Available updates background is same as toolbar
- Card corner radius has been made zero
- Update action button position has been changed which fixes the issue of text getting hidden when button text is too long in some translations
- Other elements in update card have been adjusted too to make it look better with new position of button
---
 app/src/main/res/layout/activity_updates.xml |   2 +-
 app/src/main/res/layout/update_item_view.xml | 189 +++++++++----------
 2 files changed, 95 insertions(+), 96 deletions(-)

diff --git a/app/src/main/res/layout/activity_updates.xml b/app/src/main/res/layout/activity_updates.xml
index 594cfbac..871ac035 100644
--- a/app/src/main/res/layout/activity_updates.xml
+++ b/app/src/main/res/layout/activity_updates.xml
@@ -140,7 +140,7 @@
             android:paddingBottom="24dp"
             android:paddingStart="16dp"
             android:textSize="16sp"
-            android:background="?attr/colorPrimary"
+            android:background="@color/toolbar_collapsed"
             android:text="@string/e_available_updates"
             android:textColor="?android:textColorPrimary" />
 
diff --git a/app/src/main/res/layout/update_item_view.xml b/app/src/main/res/layout/update_item_view.xml
index 8c29dc79..fdecfead 100644
--- a/app/src/main/res/layout/update_item_view.xml
+++ b/app/src/main/res/layout/update_item_view.xml
@@ -8,112 +8,60 @@
     android:focusable="true"
     android:foreground="?attr/selectableItemBackground"
     android:nextFocusRight="@+id/update_action"
-    android:layout_marginTop="8dp"
-    android:layout_marginStart="8dp"
-    android:layout_marginEnd="8dp"
-    app:cardCornerRadius="16dp"
+    app:cardCornerRadius="0dp"
     app:contentPadding="16dp">
 
     <LinearLayout
-        android:layout_width="match_parent"
-        android:layout_height="match_parent"
-        android:orientation="horizontal"
-        android:weightSum="1"
-        android:baselineAligned="false">
+        android:layout_width="wrap_content"
+        android:layout_height="wrap_content"
+        android:layout_weight="1"
+        android:orientation="vertical">
 
         <LinearLayout
-            android:layout_width="0dp"
-            android:layout_height="wrap_content"
-            android:layout_weight="1"
-            android:orientation="vertical">
-
-            <TextView
-                android:id="@+id/build_version"
-                android:layout_width="wrap_content"
-                android:layout_height="wrap_content"
-                android:alpha="0.87"
-                android:drawablePadding="8dp"
-                android:maxLines="1"
-                android:paddingBottom="8sp"
-                android:textColor="?android:attr/textColorPrimary"
-                android:textSize="16sp"
-                tools:text="LineageOS 20" />
-
-            <TextView
-                android:id="@+id/upgrade_type"
-                android:textColor="@color/theme_accent"
-                android:layout_width="wrap_content"
-                android:layout_height="wrap_content"
-                android:maxLines="1"
-                android:text="@string/e_version_upgrade_dialog_title"
-                android:textSize="14sp"
-                android:visibility="gone"
-                tools:text="@string/e_version_upgrade_dialog_title"
-                tools:visibility="visible" />
+            android:layout_width="match_parent"
+            android:layout_height="match_parent"
+            android:orientation="horizontal"
+            android:weightSum="1"
+            android:baselineAligned="false">
 
-            <TextView
-                android:id="@+id/build_date"
-                android:layout_width="wrap_content"
+            <LinearLayout
+                android:layout_width="0dp"
                 android:layout_height="wrap_content"
-                android:maxLines="1"
-                android:textSize="14sp"
-                tools:text="18 June 2023" />
+                android:layout_weight="1"
+                android:orientation="vertical">
 
-            <RelativeLayout
-                android:layout_width="wrap_content"
-                android:layout_height="wrap_content">
-
-                <LinearLayout
-                    android:layout_width="match_parent"
+                <TextView
+                    android:id="@+id/build_version"
+                    android:layout_width="wrap_content"
                     android:layout_height="wrap_content"
-                    android:id="@+id/progress"
-                    android:visibility="invisible"
-                    tools:visibility="visible">
-
-                    <ProgressBar
-                        android:id="@+id/progress_bar"
-                        style="@style/Widget.AppCompat.ProgressBar.Horizontal"
-                        android:layout_width="0dp"
-                        android:layout_weight="1"
-                        android:layout_height="wrap_content"
-                        android:paddingTop="4sp"
-                        tools:progress="65" />
-
-                    <TextView
-                        android:id="@+id/progress_percent"
-                        android:layout_width="wrap_content"
-                        android:layout_height="wrap_content"
-                        android:paddingStart="8dp"
-                        android:paddingEnd="8dp"
-                        tools:text="65%" />
-                </LinearLayout>
+                    android:alpha="0.87"
+                    android:drawablePadding="8dp"
+                    android:maxLines="1"
+                    android:paddingBottom="8sp"
+                    android:textColor="?android:attr/textColorPrimary"
+                    android:textSize="16sp"
+                    tools:text="LineageOS 20" />
 
                 <TextView
-                    android:id="@+id/progress_text"
+                    android:id="@+id/upgrade_type"
+                    android:textColor="@color/theme_accent"
                     android:layout_width="wrap_content"
                     android:layout_height="wrap_content"
-                    android:layout_below="@id/progress"
-                    android:ellipsize="marquee"
-                    android:singleLine="true"
-                    android:visibility="invisible"
-                    tools:text="162 of 1.1 GB (3 minutes left)"
+                    android:maxLines="1"
+                    android:text="@string/e_version_upgrade_dialog_title"
+                    android:textSize="14sp"
+                    android:visibility="gone"
+                    tools:text="@string/e_version_upgrade_dialog_title"
                     tools:visibility="visible" />
 
                 <TextView
-                    android:id="@+id/build_size"
+                    android:id="@+id/build_date"
                     android:layout_width="wrap_content"
                     android:layout_height="wrap_content"
-                    android:paddingTop="8sp"
-                    android:singleLine="true"
-                    tools:text="1.1 GB"
-                    tools:visibility="invisible" />
-            </RelativeLayout>
-        </LinearLayout>
-
-        <LinearLayout
-            android:layout_width="wrap_content"
-            android:layout_height="wrap_content"
-            android:orientation="vertical">
+                    android:maxLines="1"
+                    android:textSize="14sp"
+                    tools:text="18 June 2023" />
+            </LinearLayout>
             <ImageButton
                 android:id="@+id/update_menu"
                 style="?android:attr/actionOverflowButtonStyle"
@@ -122,14 +70,65 @@
                 android:layout_gravity="end"
                 android:padding="8dp"
                 android:contentDescription="@null" />
-            <Button
-                android:id="@id/update_action"
-                style="@style/Widget.AppCompat.Button.Borderless.Colored"
-                android:background="?android:selectableItemBackgroundBorderless"
+
+        </LinearLayout>
+
+        <RelativeLayout
+            android:layout_width="wrap_content"
+            android:layout_height="wrap_content">
+
+            <LinearLayout
+                android:layout_width="match_parent"
+                android:layout_height="wrap_content"
+                android:id="@+id/progress"
+                android:visibility="invisible"
+                tools:visibility="visible">
+
+                <ProgressBar
+                    android:id="@+id/progress_bar"
+                    style="@style/Widget.AppCompat.ProgressBar.Horizontal"
+                    android:layout_width="0dp"
+                    android:layout_weight="1"
+                    android:layout_height="wrap_content"
+                    android:paddingTop="4sp"
+                    tools:progress="65" />
+
+                <TextView
+                    android:id="@+id/progress_percent"
+                    android:layout_width="wrap_content"
+                    android:layout_height="wrap_content"
+                    android:paddingStart="8dp"
+                    android:paddingEnd="8dp"
+                    tools:text="65%" />
+            </LinearLayout>
+
+            <TextView
+                android:id="@+id/progress_text"
                 android:layout_width="wrap_content"
                 android:layout_height="wrap_content"
-                android:padding="8dp"
-                tools:text="Pause" />
-        </LinearLayout>
+                android:layout_below="@id/progress"
+                android:ellipsize="marquee"
+                android:singleLine="true"
+                android:visibility="invisible"
+                tools:text="162 of 1.1 GB (3 minutes left)"
+                tools:visibility="visible" />
+
+            <TextView
+                android:id="@+id/build_size"
+                android:layout_width="wrap_content"
+                android:layout_height="wrap_content"
+                android:paddingTop="8sp"
+                android:singleLine="true"
+                tools:text="1.1 GB"
+                tools:visibility="invisible" />
+        </RelativeLayout>
+        <Button
+            android:id="@id/update_action"
+            style="@style/Widget.AppCompat.Button.Borderless.Colored"
+            android:layout_width="wrap_content"
+            android:layout_height="wrap_content"
+            android:layout_gravity="center"
+            android:padding="8dp"
+            tools:text="Pause" />
     </LinearLayout>
 </androidx.cardview.widget.CardView>
-- 
GitLab