Use helper function for parsing version code (b15e9e17) · Commits · e / os / android_packages_apps_Updater

src/org/lineageos/updater/misc/Utils.java

+34 −6

Original line number	Diff line number	Diff line
		@@ -53,6 +53,8 @@ import java.util.Locale;
		import java.util.Set;
		import java.util.zip.ZipEntry;
		import java.util.zip.ZipFile;
		import java.util.regex.Pattern;


		public class Utils {

		@@ -96,10 +98,17 @@ public class Utils {
		}

		public static boolean isCompatible(UpdateBaseInfo update) {
		if (update.getVersion().compareTo(SystemProperties.get(Constants.PROP_BUILD_VERSION)) < 0) {
		Log.d(TAG, update.getName() + " is older than current Android version");
		return false;
		}
		int[] updateVersionParts = parseSemVer(update.getVersion());
		int updateMajorVersion = updateVersionParts[0];
		int updateMinorVersion = updateVersionParts[1];
		Log.d(TAG, "Update : Major "+updateMajorVersion +" Minor "+ updateMinorVersion );

		int[] deviceVersionParts = parseSemVer(SystemProperties.get(Constants.PROP_BUILD_VERSION));
		int deviceMajorVersion = deviceVersionParts[0];
		int deviceMinorVersion = deviceVersionParts[1];
		Log.d(TAG, "Device : Major "+ deviceMajorVersion +" Minor "+ deviceMinorVersion );


		if (!SystemProperties.getBoolean(Constants.PROP_UPDATER_ALLOW_DOWNGRADING, false) &&
		update.getTimestamp() <= SystemProperties.getLong(Constants.PROP_BUILD_DATE, 0)) {
		Log.d(TAG, update.getName() + " is older than/equal to the current build");
		@@ -109,9 +118,29 @@ public class Utils {
		Log.d(TAG, update.getName() + " has type " + update.getType());
		return false;
		}
		if(updateMajorVersion > deviceMajorVersion){
		Log.d(TAG, update.getName() + " is Newer to current Major version");
		return true;
		}
		if(updateMajorVersion < deviceMajorVersion){
		Log.d(TAG, update.getName() + " is Older to current Major version");
		return false;
		}
		if(updateMinorVersion < deviceMinorVersion){
		Log.d(TAG, update.getName() + " is Older to current Minor version");
		return false;
		}

		return true;
		}

		public static int[] parseSemVer(String versionCode) {
		String[] versionParts = versionCode.split(Pattern.quote("."));
		int major = Integer.parseInt(versionParts[0]);
		int minor = Integer.parseInt(versionParts[1]);
		return new int[]{ major, minor };
		}

		public static boolean canInstall(UpdateBaseInfo update) {
		return (SystemProperties.getBoolean(Constants.PROP_UPDATER_ALLOW_DOWNGRADING, false) \|\|
		update.getTimestamp() > SystemProperties.getLong(Constants.PROP_BUILD_DATE, 0));
		@@ -172,7 +201,6 @@ public class Utils {
		}

		public static String getChangelogURL(Context context) {

		String buildVersion = SystemProperties.get(Constants.PROP_BUILD_VERSION);

		return context.getString(R.string.menu_changelog_url, buildVersion);