Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 27968c44 authored by Gabriele M's avatar Gabriele M
Browse files

Don't use one shot PendingIntents for the notification actions 

FLAG_ONE_SHOT doesn't make so much sense here, the intents are generic
and can be repeated.

Change-Id: Ib457d975387dfd838372639e2aaa40a3df6f4d15
parent 4ccf010e

src/org/lineageos/updater/ExportUpdateService.java

+1 −2
Original line number Diff line number Diff line
@@ -200,7 +200,6 @@ public class ExportUpdateService extends Service { 
    private PendingIntent getStopPendingIntent() {

        final Intent intent = new Intent(this, ExportUpdateService.class);

        intent.setAction(ACTION_STOP_EXPORTING);

        return PendingIntent.getService(this, 0, intent,

                PendingIntent.FLAG_ONE_SHOT | PendingIntent.FLAG_UPDATE_CURRENT);

        return PendingIntent.getService(this, 0, intent, PendingIntent.FLAG_UPDATE_CURRENT);

    }

}

src/org/lineageos/updater/controller/UpdaterService.java

+3 −6
Original line number Diff line number Diff line
@@ -436,8 +436,7 @@ public class UpdaterService extends Service { 
        intent.setAction(ACTION_DOWNLOAD_CONTROL);

        intent.putExtra(EXTRA_DOWNLOAD_ID, downloadId);

        intent.putExtra(EXTRA_DOWNLOAD_CONTROL, DOWNLOAD_RESUME);

        return PendingIntent.getService(this, 0, intent,

                PendingIntent.FLAG_ONE_SHOT | PendingIntent.FLAG_UPDATE_CURRENT);

        return PendingIntent.getService(this, 0, intent, PendingIntent.FLAG_UPDATE_CURRENT);

    }



    private PendingIntent getPausePendingIntent(String downloadId) {
@@ -445,15 +444,13 @@ public class UpdaterService extends Service { 
        intent.setAction(ACTION_DOWNLOAD_CONTROL);

        intent.putExtra(EXTRA_DOWNLOAD_ID, downloadId);

        intent.putExtra(EXTRA_DOWNLOAD_CONTROL, DOWNLOAD_PAUSE);

        return PendingIntent.getService(this, 0, intent,

                PendingIntent.FLAG_ONE_SHOT | PendingIntent.FLAG_UPDATE_CURRENT);

        return PendingIntent.getService(this, 0, intent, PendingIntent.FLAG_UPDATE_CURRENT);

    }



    private PendingIntent getRebootPendingIntent() {

        final Intent intent = new Intent(this, UpdaterReceiver.class);

        intent.setAction(UpdaterReceiver.ACTION_INSTALL_REBOOT);

        return PendingIntent.getBroadcast(this, 0, intent,

                PendingIntent.FLAG_ONE_SHOT | PendingIntent.FLAG_UPDATE_CURRENT);

        return PendingIntent.getBroadcast(this, 0, intent, PendingIntent.FLAG_UPDATE_CURRENT);

    }



}