Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f8441cc2 authored by Jon Miranda's avatar Jon Miranda
Browse files

Fix notification dot not always being up to date. 

- Prediction row views were never updated when notification changes.
- FloatingIconView set the BubbleTextView to force hide dot, but never restored it.
  BubbleTextView is instanceof IconLabelDotView, so its already handled in the end runnable

Bug: 183360736
Test: 1. swipe up to go home such that the closing app has a notification,
         note that the notification dot is properly updated
      2. have all apps open
         make notification update for a predicted app
         ensure dot is properly updated

Change-Id: I35dacf9b71a3d8b8a857be450690d65ea9199bf6
parent d2182b24

quickstep/src/com/android/launcher3/appprediction/PredictionRowView.java

+7 −0
Original line number Diff line number Diff line
@@ -96,6 +96,13 @@ public class PredictionRowView extends LinearLayout implements 


    private void updateVisibility() {

        setVisibility(mPredictionsEnabled ? VISIBLE : GONE);

        if (mLauncher.getAppsView() != null) {

            if (mPredictionsEnabled) {

                mLauncher.getAppsView().getAppsStore().registerIconContainer(this);

            } else {

                mLauncher.getAppsView().getAppsStore().unregisterIconContainer(this);

            }

        }

    }



    @Override

src/com/android/launcher3/allapps/AllAppsStore.java

+1 −1
Original line number Diff line number Diff line
@@ -132,7 +132,7 @@ public class AllAppsStore { 
    }



    public void registerIconContainer(ViewGroup container) {

        if (container != null) {

        if (container != null && !mIconContainers.contains(container)) {

            mIconContainers.add(container);

        }

    }

src/com/android/launcher3/views/FloatingIconView.java

+0 −5
Original line number Diff line number Diff line
@@ -580,11 +580,6 @@ public class FloatingIconView extends FrameLayout implements 
                    if (originalView instanceof IconLabelDotView) {

                        setIconAndDotVisible(originalView, true);

                    }

                    if (originalView instanceof BubbleTextView) {

                        BubbleTextView btv = (BubbleTextView) originalView;

                        btv.setIconVisible(true);

                        btv.setForceHideDot(true);

                    }

                    view.finish(dragLayer);

                }

            } else {