Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f595fc31 authored by Sergey Pinkevich's avatar Sergey Pinkevich
Browse files

Place app icons in correct place in RTL for Seascape mode 

The goal for this CL is to show icons for split apps (similar to Landscape mode). The aligning (perfect pixel, aligned to the task bounds) can be done in a separate task

Bug: 317072320
Flag: NONE
Test: manually

Old behavior: https://drive.google.com/file/d/11UQyEB-EhKYu1eisjAW_MnhV-drrT38E/view?usp=sharing (icons are missing in RTL mode)

New behavior: https://drive.google.com/file/d/1GrZe6J8zBIoHtP7DzgZnpJiyz2XWujLf/view?usp=sharing

Change-Id: I2fe7defd1c668326ab0e0114a4cd9793e66d6175
parent dacd86e0

src/com/android/launcher3/touch/SeascapePagedViewHandler.java

+17 −6
Original line number Diff line number Diff line
@@ -285,7 +285,7 @@ public class SeascapePagedViewHandler extends LandscapePagedViewHandler { 
        primaryIconView.setTranslationX(0);

        secondaryIconView.setTranslationX(0);

        if (enableOverviewIconMenu()) {

            if (primaryIconView.getLayoutDirection() == LAYOUT_DIRECTION_RTL) {

            if (isRtl) {

                primaryIconView.setTranslationY(groupedTaskViewHeight - primarySnapshotHeight);

                secondaryIconView.setTranslationY(0);

            } else {
@@ -295,15 +295,26 @@ public class SeascapePagedViewHandler extends LandscapePagedViewHandler { 
        } else if (splitConfig.initiatedFromSeascape) {

            // if the split was initiated from seascape,

            // the task on the right (secondary) is slightly larger

            if (isRtl) {

                primaryIconView.setTranslationY(bottomToMidpointOffset - insetOffset

                        + taskIconHeight);

                secondaryIconView.setTranslationY(bottomToMidpointOffset - insetOffset);

            } else {

                primaryIconView.setTranslationY(-bottomToMidpointOffset - insetOffset

                        + taskIconHeight);

                secondaryIconView.setTranslationY(-bottomToMidpointOffset - insetOffset);

            }

        } else {

            // if not,

            // the task on the left (primary) is slightly larger

            if (isRtl) {

                primaryIconView.setTranslationY(bottomToMidpointOffset + taskIconHeight);

                secondaryIconView.setTranslationY(bottomToMidpointOffset);

            } else {

                primaryIconView.setTranslationY(-bottomToMidpointOffset + taskIconHeight);

                secondaryIconView.setTranslationY(-bottomToMidpointOffset);

            }

        }



        primaryIconView.setLayoutParams(primaryIconParams);

        secondaryIconView.setLayoutParams(secondaryIconParams);