Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit de43fb63 authored by Vinit Nayak's avatar Vinit Nayak
Browse files

Notify TaskViews of updated orientation state 

There was a race condition between when recent
tasks get loaded for overview and when the
RecentsOrientationState gets updated based on
which orientation was touched. Now notify
tasks view every time orientation state
updates.

Fixes: 160912655
Test: Kill launcher while landscape app
is open then swipe up to recents.
App in correct location.

Change-Id: If2b239f748c000257bd91b14a23d68ba026e3a48
parent 032db328

quickstep/recents_ui_overrides/src/com/android/quickstep/views/RecentsView.java

+4 −3
Original line number Diff line number Diff line
@@ -377,7 +377,7 @@ public abstract class RecentsView<T extends StatefulActivity> extends PagedView 
                    mOrientationState.setMultiWindowMode(inMultiWindowMode);

                    setLayoutRotation(mOrientationState.getTouchRotation(),

                            mOrientationState.getDisplayRotation());

                    rotateAllChildTasks();

                    updateChildTaskOrientations();

                }

                if (!inMultiWindowMode && mOverviewStateEnabled) {

                    // TODO: Re-enable layout transitions for addition of the unpinned task
@@ -1073,7 +1073,7 @@ public abstract class RecentsView<T extends StatefulActivity> extends PagedView 
        pa.addListener(AnimationSuccessListener.forRunnable(() -> {

            setLayoutRotation(newRotation, mOrientationState.getDisplayRotation());

            mActivity.getDragLayer().recreateControllers();

            rotateAllChildTasks();

            updateChildTaskOrientations();

            setRecentsChangedOrientation(false).start();

        }));

        pa.start();
@@ -1094,7 +1094,7 @@ public abstract class RecentsView<T extends StatefulActivity> extends PagedView 
    }





    private void rotateAllChildTasks() {

    private void updateChildTaskOrientations() {

        for (int i = 0; i < getTaskViewCount(); i++) {

            getTaskViewAt(i).setOrientationState(mOrientationState);

        }
@@ -1677,6 +1677,7 @@ public abstract class RecentsView<T extends StatefulActivity> extends PagedView 
                || mOrientationState.getRecentsActivityRotation() != ROTATION_0;

        mActionsView.updateHiddenFlags(HIDDEN_NON_ZERO_ROTATION,

                !mOrientationState.canRecentsActivityRotate() && isInLandscape);

        updateChildTaskOrientations();

        resetPaddingFromTaskSize();

        requestLayout();

        // Reapply the current page to update page scrolls.